FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Split linting from main workflow by m-aciek · Pull Request #144 · python/python-docs-pl · GitHub

/ python-docs-pl Public

Split linting from main workflow - #144

Merged
m-aciek merged 23 commits into
3.15from
split-linting-from-main-workflow
Jun 27, 2026
ConversationCommits (23)ChecksFiles changed
Merged

Split linting from main workflow#144
m-aciek merged 23 commits into
3.15from
split-linting-from-main-workflow

Conversation

m-aciek commented Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

By splitting workflows we get a better, gradual feedback and state of things expression.

Building without strict mode, we can add back strict mode as a separate workflow (or as part of linting?) in the future.

Updated READMEs with new workflow links. Extra changes: dropped translations mailing list and added a link to Sphinx translation.

Unable to test workflow run trigger before the PR is merged into main.

To do:

m-aciek commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator Author

Posted a PR fixing the failure cause: python/cpython#151343

StanFromIreland commented Jun 11, 2026

Copy link
Copy Markdown
Member

Posted a PR fixing the failure cause: python/cpython#151343

Thanks, merged!

StanFromIreland reviewed Jun 11, 2026
View reviewed changes
Comment thread .github/workflows/lint.yml Outdated
m-aciek marked this pull request as ready for review June 11, 2026 19:41
m-aciek requested a review from StanFromIreland June 11, 2026 19:43
StanFromIreland reviewed Jun 12, 2026
View reviewed changes
Comment thread .github/workflows/update-and-build.yml
- run: git add .
- run: git commit -m "$(python manage_translation.py generate_commit_msg)"
if: env.SIGNIFICANT_CHANGES
- name: Push commit

StanFromIreland Jun 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This shouldn't run on PRs IMO. This causes issues like https://github.com/python/python-docs-pl/actions/runs/27407678283/job/81000784306?pr=144.

m-aciek Jun 15, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

added a skip

StanFromIreland reviewed Jun 12, 2026
View reviewed changes
Comment thread .github/workflows/lint.yml
Comment thread .github/workflows/update-and-build.yml Outdated
Comment thread .github/workflows/lint.yml
m-aciek requested a review from StanFromIreland June 15, 2026 22:01

m-aciek commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator Author

@copilot resolve the merge conflicts in this pull request

StanFromIreland commented Jun 24, 2026

Copy link
Copy Markdown
Member

Oh no, sorry this slipped my mind. I'll review later today.

python-cla-bot Bot commented Jun 24, 2026

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

Copilot AI commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Resolved in b1e0efc. The conflicts were in the auto-generated badge stats sections of both README files — took the newer translation percentages from 3.15 while keeping the lint.yml workflow link from this branch.

StanFromIreland reviewed Jun 24, 2026
View reviewed changes
Comment thread .github/workflows/update-and-build.yml Outdated
- name: Push commit
uses: ad-m/github-push-action@881a6320fdb16eb5318c5054f31c218aec2b324c # v1.3.0
if: env.SIGNIFICANT_CHANGES
if: env.SIGNIFICANT_CHANGES && (github.event.workflow_run.head_branch == github.event.repository.default_branch)

StanFromIreland Jun 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

There's no workflow_run trigger?

Comment thread .github/workflows/lint.yml Outdated

m-aciek commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator Author

@copilot resolve the merge conflicts in this pull request

Copilot AI commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Resolved in 6bd439f — merged 3.15 into this branch, keeping the lint.yml workflow URL and the newer translation stats from HEAD.

m-aciek requested a review from StanFromIreland June 26, 2026 08:28
StanFromIreland approved these changes Jun 26, 2026
View reviewed changes

StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Comment thread .github/workflows/lint.yml Outdated
Unify python-version in setup step
fafb4a3 
Co-authored-by: Stan Ulbrych <stanulbrych@gmail.com>
m-aciek merged commit e705c94 into 3.15 Jun 27, 2026
7 of 8 checks passed
m-aciek deleted the split-linting-from-main-workflow branch June 27, 2026 12:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

StanFromIreland StanFromIreland approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL