| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
LGTM. Should we add a test to the scaling benchmark that reproduces the issue?
Sorry, something went wrong.
| _PyThreadState_PushCStackRef(tstate, &mro_ref); | ||
| mro_ref.ref = PyStackRef_FromPyObjectNew(mro); |
There was a problem hiding this comment.
Doesn't need to be in this PR, but would it be worth adding another function that combines these two operations?
Sorry, something went wrong.
There was a problem hiding this comment.
Yeah, makes sense.
Sorry, something went wrong.
|
This is enough to fix super() on different classes, but not enough for the straightforward super() on the same class. That'll require some additional fixes. I'll add the scaling benchmark in a follow up together with those fixes: class Base:
def method(self):
return 1
class Derived(Base):
def method(self):
return super().method()
@register_benchmark
def super_call():
obj = Derived()
for _ in range(1000 * WORK_SCALE):
obj.method() |
Sorry, something went wrong.
|
Actually, maybe it's worth adding the different class benchmark now and I'll update it later. |
Sorry, something went wrong.
|
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
|
Sorry, @colesbury, I could not cleanly backport this to 3.14 due to a conflict. cherry_picker bdf6de8c3f0c2ec0d737f38014a32c1eed02c7f1 3.14 |
Sorry, something went wrong.
…ups (pythongh-145775) (cherry picked from commit bdf6de8) Co-authored-by: Sam Gross <colesbury@gmail.com>
|
GH-145804 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.