FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.13] gh-145098: Run Apple Silicon macOS CI on macos-26 (Tahoe) (GH-145099) (GH-146412) by hugovk · Pull Request #146414 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

[3.13] gh-145098: Run Apple Silicon macOS CI on macos-26 (Tahoe) (GH-145099) (GH-146412) - #146414

Merged
hugovk merged 3 commits into
python:3.13from
hugovk:backport-ce78904-3.13
Mar 30, 2026
ConversationCommits (3)ChecksFiles changed
Merged

[3.13] gh-145098: Run Apple Silicon macOS CI on macos-26 (Tahoe) (GH-145099) (GH-146412)#146414
hugovk merged 3 commits into
python:3.13from
hugovk:backport-ce78904-3.13

Conversation

hugovk commented Mar 25, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

[3.13] pythongh-145098: Run Apple Silicon macOS CI on macos-26 (Tahoe) (
2ccc917 
pythonGH-145099) (pythonGH-146412)

(cherry picked from commit ce78904)

Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Co-authored-by: clintonsteiner <47841949+clintonsteiner@users.noreply.github.com>
bedevere-app Bot mentioned this pull request Mar 25, 2026
Closed
hugovk added the needs backport to 3.12 only security fixes label Mar 25, 2026
bedevere-app Bot mentioned this pull request Mar 25, 2026
Merged

hugovk commented Mar 25, 2026

Copy link
Copy Markdown
Member Author

Some JIT failures here, does it need some updates to work with macOS 26?

vstinner commented Mar 27, 2026

Copy link
Copy Markdown
Member

JIT build error:

In file included from /Users/runner/work/cpython/cpython/Tools/jit/trampoline.c:1:
/Users/runner/work/cpython/cpython/Include/Python.h:20:10: fatal error: 'assert.h' file not found

This error looks like #126464 which was solved by #126494. It seems like .github/workflows/jit.yml miss this change in the 3.13 branch.

vstinner commented Mar 27, 2026

Copy link
Copy Markdown
Member

@hugovk: Can you try this change on your PR?

diff --git a/.github/workflows/jit.yml b/.github/workflows/jit.yml
index fc019fb0d32..ffd49ca2834 100644
--- a/.github/workflows/jit.yml
+++ b/.github/workflows/jit.yml
@@ -133,8 +133,8 @@ jobs:
         run: |
           brew update
           brew install llvm@${{ matrix.llvm }}
-          SDKROOT="$(xcrun --show-sdk-path)" \
-            ./configure --enable-experimental-jit ${{ matrix.debug && '--with-pydebug' || '--enable-optimizations --with-lto' }}
+          export SDKROOT="$(xcrun --show-sdk-path)"
+          ./configure --enable-experimental-jit ${{ matrix.debug && '--with-pydebug' || '--enable-optimizations --with-lto' }}
           make all --jobs 4
           ./python.exe -m test --multiprocess 0 --timeout 4500 --verbose2 --verbose3

hugovk mentioned this pull request Mar 27, 2026
Merged

hugovk commented Mar 30, 2026

Copy link
Copy Markdown
Member Author

JIT macOS tests are now passing.

JIT aarch64-unknown-linux are consistently failing, but unrelated to these changes they are also on 3.13:

https://github.com/python/cpython/actions/runs/22593670441

And CIFuzz consistently failing, but also unrelated to these changes.

hugovk merged commit 0dcb625 into python:3.13 Mar 30, 2026
158 of 173 checks passed
hugovk deleted the backport-ce78904-3.13 branch March 30, 2026 13:21

miss-islington-app Bot commented Mar 30, 2026

Copy link
Copy Markdown

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington-app Bot commented Mar 30, 2026

Copy link
Copy Markdown

Sorry, @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0dcb625be4410026f53df515282674d7908b005f 3.12

bedevere-app Bot commented Mar 30, 2026

Copy link
Copy Markdown

GH-146635 is a backport of this pull request to the 3.12 branch.

hugovk added a commit to hugovk/cpython that referenced this pull request Mar 30, 2026
[3.12] pythongh-145098: Run Apple Silicon macOS CI on macos-26 (Tahoe) (
c41f317 
pythonGH-145099) (pythonGH-146412) (pythonGH-146414)

(cherry picked from commit 0dcb625)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Co-authored-by: clintonsteiner <47841949+clintonsteiner@users.noreply.github.com>
bedevere-app Bot removed the needs backport to 3.12 only security fixes label Mar 30, 2026
hugovk added a commit that referenced this pull request Mar 30, 2026
[3.12] gh-145098: Run Apple Silicon macOS CI on macos-26 (Tahoe) (GH-…
7f2d89a 
…145099) (GH-146412) (GH-146414) (#146635)

Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Co-authored-by: clintonsteiner <47841949+clintonsteiner@users.noreply.github.com>
hugovk added a commit that referenced this pull request Mar 30, 2026
[3.11] gh-145098: Run Apple Silicon macOS CI on macos-26 (Tahoe) (GH-…
5ed08c4 
…145099) (GH-146412) (GH-146414) (GH-146635) (#146638)

Co-authored-by: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Co-authored-by: clintonsteiner <47841949+clintonsteiner@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

brandtbucher Awaiting requested review from brandtbucher brandtbucher is a code owner
savannahostrowski Awaiting requested review from savannahostrowski savannahostrowski is a code owner
ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Assignees

hugovk

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL