FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-146416: Emscripten: Improve standard stream handling in node_entry.mjs by hoodmane · Pull Request #146417 · python/cpython · GitHub

/ cpython Public

gh-146416: Emscripten: Improve standard stream handling in node_entry.mjs - #146417

Merged
vstinner merged 8 commits into
python:mainfrom
hoodmane:streams
Mar 30, 2026
ConversationCommits (8)ChecksFiles changed
Merged

gh-146416: Emscripten: Improve standard stream handling in node_entry.mjs#146417
vstinner merged 8 commits into
python:mainfrom
hoodmane:streams

Conversation

hoodmane commented Mar 25, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

hoodmane requested review from freakboy3742 and removed request for AA-Turner, corona10, emmatyping and erlend-aasland March 25, 2026 13:13
bedevere-app Bot mentioned this pull request Mar 25, 2026
Closed

vstinner commented Mar 25, 2026

Copy link
Copy Markdown
Member

The test suite fails on Emscripten with nodeFsync is not defined: https://github.com/python/cpython/actions/runs/23545540285/job/68544804717?pr=146417

0:00:13 load avg: 0.10 [ 78/502] test.test_os.test_os
file:///home/runner/work/cpython/cpython/cross-build/wasm32-emscripten/build/python/streams.mjs:189
    nodeFsync(this.nodeStream.fd);
    ^

ReferenceError: nodeFsync is not defined
    at NodeWriter.fsync (file:///home/runner/work/cpython/cpython/cross-build/wasm32-emscripten/build/python/streams.mjs:189:5)
    at Object.fsync (file:///home/runner/work/cpython/cpython/cross-build/wasm32-emscripten/build/python/streams.mjs:136:11)
    at Object.close (file:///home/runner/work/cpython/cpython/cross-build/wasm32-emscripten/build/python/streams.mjs:131:23)
    at Object.close (file:///home/runner/work/cpython/cpython/cross-build/wasm32-emscripten/build/python/python.mjs:1:71931)
    at _fd_close (file:///home/runner/work/cpython/cpython/cross-build/wasm32-emscripten/build/python/python.mjs:1:271594)
    at wasm://wasm/02b6ddae:wasm-function[12183]:0x69a8ab
    at wasm://wasm/02b6ddae:wasm-function[8357]:0x498ddf
    at wasm://wasm/02b6ddae:wasm-function[1978]:0x1e167a
    at wasm://wasm/02b6ddae:wasm-function[803]:0x18e943
    at wasm://wasm/02b6ddae:wasm-function[3473]:0x2ad92d

Node.js v24.14.0
Error: Process completed with exit code 1.

vstinner reviewed Mar 30, 2026
View reviewed changes
Comment thread Platforms/emscripten/streams.mjs Outdated
Comment thread Platforms/emscripten/streams.mjs Outdated
Comment thread Platforms/emscripten/streams.mjs Outdated
hoodmane and others added 2 commits March 30, 2026 12:05
Apply suggestions from code review
245cb86 
Co-authored-by: Victor Stinner <vstinner@python.org>
Sleep only 10ms
36a307e

hoodmane commented Mar 30, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the review @vstinner!

vstinner approved these changes Mar 30, 2026
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

vstinner merged commit 6857de6 into python:main Mar 30, 2026
50 checks passed

miss-islington-app Bot commented Mar 30, 2026

Copy link
Copy Markdown

Thanks @hoodmane for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 30, 2026
pythongh-146416: Emscripten: Improve standard stream handling in node…
2d93923 
…_entry.mjs (pythonGH-146417)

(cherry picked from commit 6857de6)

Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>

bedevere-app Bot commented Mar 30, 2026

Copy link
Copy Markdown

GH-146630 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Mar 30, 2026
hoodmane deleted the streams branch March 30, 2026 11:28
vstinner added a commit that referenced this pull request Mar 30, 2026
[3.14] gh-146416: Emscripten: Improve standard stream handling in nod…
ec11485 
…e_entry.mjs (GH-146417) (#146630)

gh-146416: Emscripten: Improve standard stream handling in node_entry.mjs (GH-146417)
(cherry picked from commit 6857de6)

Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
maurycy added a commit to maurycy/cpython that referenced this pull request Mar 30, 2026
Merge remote-tracking branch 'upstream/main' into tachyon-ndjson-kole…
6a0ea81 
…ktor

* upstream/main: (119 commits)
  pythongh-144270: Make SubElement parent and tag positional-only (pythonGH-144845)
  pythongh-146558: JIT optimize dict access for objects with known hash (python#146559)
  pythongh-139922: always run MSVC 64-bit tail-calling CI (pythonGH-146570)
  pythongh-126835: Fix _PY_IS_SMALL_INT() macro (python#146631)
  pythongh-146587: fix type slot assignment incase of multiple slots for same name (python#146593)
  pythongh-138122: Add differential flame graph (python#145785)
  pythongh-146416: Emscripten: Improve standard stream handling in node_entry.mjs (python#146417)
  pythongh-146444: Don't package as part of iOS 'build hosts' target (python#146628)
  pythongh-138850: Add --disable-epoll to configure (pythonGH-145768)
  pythongh-146444: Make Platforms/Apple/ compatible with Python 3.9 (python#146624)
  pythongh-138577: Fix keyboard shortcuts in getpass with echo_char (python#141597)
  pythongh-146556: Fix infinite loop in annotationlib.get_annotations() on circular __wrapped__ (python#146557)
  pythongh-146579: _zstd: Fix decompression options dict error message (python#146577)
  pythongh-146083: Upgrade bundled Expat to 2.7.5 (python#146085)
  pythongh-146080: fix a crash in SNI callbacks when the SSL object is gone (python#146573)
  pythongh-146090: fix memory management of internal `sqlite3` callback contexts (python#146569)
  pythongh-145876: Do not mask KeyErrors raised during dictionary unpacking in call (pythonGH-146472)
  pythongh-146004: fix test_args_from_interpreter_flags on windows (python#146580)
  pythongh-139003: Use frozenset for module level attributes in _pyrepl.utils (python#139004)
  pythonGH-146527: Add more data to GC statistics and add it to PyDebugOffsets (python#146532)
  ...
pablogsal mentioned this pull request Apr 4, 2026
Merged
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Apr 16, 2026
pythongh-146416: Emscripten: Improve standard stream handling in node…
5d24496 
…_entry.mjs (python#146417)

Co-authored-by: Victor Stinner <vstinner@python.org>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythongh-146416: Emscripten: Improve standard stream handling in node…
5df80ab 
…_entry.mjs (python#146417)

Co-authored-by: Victor Stinner <vstinner@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
freakboy3742 Awaiting requested review from freakboy3742 freakboy3742 is a code owner

Assignees

No one assigned

Labels

OS-emscripten skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL