| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
The TypeError in _zstd_set_d_parameters incorrectly referred to compression options; say decompression options instead.
|
I am not sure this is a bug. Should not the compression options dictionary be the same for compression and decompression? They are compression options which should be passed to decompressor to inform what options were used during compression. |
Sorry, something went wrong.
They actually differ: |
Sorry, something went wrong.
|
You are right. This check is especially to check that they are not mixed. |
Sorry, something went wrong.
There was a problem hiding this comment.
Thank you for catching this!
Sorry, something went wrong.
|
Thanks @cuiweixie for the PR, and @emmatyping for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
…ythonGH-146577) The TypeError in _zstd_set_d_parameters incorrectly referred to compression options; say decompression options instead. (cherry picked from commit 4d0e8ee) Co-authored-by: cui <cuiweixie@gmail.com>
|
GH-146611 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
…GH-146577) (#146611) The TypeError in _zstd_set_d_parameters incorrectly referred to compression options; say decompression options instead. (cherry picked from commit 4d0e8ee) Co-authored-by: cui <cuiweixie@gmail.com>
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot iOS ARM64 Simulator 3.14 (tier-3) has failed when building commit de234fc. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/#/builders/1722/builds/1143 Summary of the results of the build (if available): Click to see traceback logsremote: Enumerating objects: 5, done.
remote: Counting objects: 50% (1/2)
remote: Counting objects: 100% (2/2)
remote: Counting objects: 100% (2/2), done.
remote: Compressing objects: 50% (1/2)
remote: Compressing objects: 100% (2/2)
remote: Compressing objects: 100% (2/2), done.
remote: Total 5 (delta 0), reused 0 (delta 0), pack-reused 3 (from 1)
From https://github.com/python/cpython
* branch 3.14 -> FETCH_HEAD
Note: switching to 'de234fc07adfc94518e847abecef02527e0dd130'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:
git switch -c <new-branch-name>
Or undo this operation with:
git switch -
Turn off this advice by setting config variable advice.detachedHead to false
HEAD is now at de234fc07ad [3.14] gh-146579: _zstd: Fix decompression options dict error message (GH-146577) (#146611)
Switched to and reset branch '3.14'
Traceback (most recent call last):
File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/runpy.py", line 197, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/Users/buildbot/buildarea/3.14.rkm-arm64-ios-simulator.iOS-simulator.arm64/build/Platforms/Apple/__main__.py", line 57, in <module>
ArgsT = Sequence[str | Path]
TypeError: unsupported operand type(s) for |: 'type' and 'type'
Traceback (most recent call last):
File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/runpy.py", line 197, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/Users/buildbot/buildarea/3.14.rkm-arm64-ios-simulator.iOS-simulator.arm64/build/Platforms/Apple/__main__.py", line 57, in <module>
ArgsT = Sequence[str | Path]
TypeError: unsupported operand type(s) for |: 'type' and 'type' |
Sorry, something went wrong.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot s390x Fedora Stable Refleaks 3.14 (tier-3) has failed when building commit de234fc. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/#/builders/1776/builds/1040 Failed tests:
Failed subtests:
Summary of the results of the build (if available): == Click to see traceback logsTraceback (most recent call last):
File "/var/lib/buildbot/worker/cstratak-fedora-stable-s390x/3.14.cstratak-fedora-stable-s390x.refleak/build/Lib/test/test_os.py", line 4554, in test_timerfd_poll
self.check_timerfd_poll(False)
~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^
File "/var/lib/buildbot/worker/cstratak-fedora-stable-s390x/3.14.cstratak-fedora-stable-s390x.refleak/build/Lib/test/test_os.py", line 4542, in check_timerfd_poll
self.assertEqual(self.read_count_signaled(fd), 1)
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 2 != 1
Traceback (most recent call last):
File "/var/lib/buildbot/worker/cstratak-fedora-stable-s390x/3.14.cstratak-fedora-stable-s390x.refleak/build/Lib/test/test_external_inspection.py", line 1289, in test_only_active_thread
self.assertEqual(
~~~~~~~~~~~~~~~~^
len(gil_traces), 1, "Should have exactly one GIL holder"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
)
^
AssertionError: 0 != 1 : Should have exactly one GIL holder
|
Sorry, something went wrong.
Traceback (most recent call last):
File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/runpy.py", line 197, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/Users/buildbot/buildarea/3.14.rkm-arm64-ios-simulator.iOS-simulator.arm64/build/Platforms/Apple/__main__.py", line 57, in <module>
ArgsT = Sequence[str | Path]
TypeError: unsupported operand type(s) for |: 'type' and 'type'
It looks like we are not running the correct Python version. |
Sorry, something went wrong.
|
The Python version on the iOS buildbot should now be corrected. |
Sorry, something went wrong.
…ktor * upstream/main: (119 commits) pythongh-144270: Make SubElement parent and tag positional-only (pythonGH-144845) pythongh-146558: JIT optimize dict access for objects with known hash (python#146559) pythongh-139922: always run MSVC 64-bit tail-calling CI (pythonGH-146570) pythongh-126835: Fix _PY_IS_SMALL_INT() macro (python#146631) pythongh-146587: fix type slot assignment incase of multiple slots for same name (python#146593) pythongh-138122: Add differential flame graph (python#145785) pythongh-146416: Emscripten: Improve standard stream handling in node_entry.mjs (python#146417) pythongh-146444: Don't package as part of iOS 'build hosts' target (python#146628) pythongh-138850: Add --disable-epoll to configure (pythonGH-145768) pythongh-146444: Make Platforms/Apple/ compatible with Python 3.9 (python#146624) pythongh-138577: Fix keyboard shortcuts in getpass with echo_char (python#141597) pythongh-146556: Fix infinite loop in annotationlib.get_annotations() on circular __wrapped__ (python#146557) pythongh-146579: _zstd: Fix decompression options dict error message (python#146577) pythongh-146083: Upgrade bundled Expat to 2.7.5 (python#146085) pythongh-146080: fix a crash in SNI callbacks when the SSL object is gone (python#146573) pythongh-146090: fix memory management of internal `sqlite3` callback contexts (python#146569) pythongh-145876: Do not mask KeyErrors raised during dictionary unpacking in call (pythonGH-146472) pythongh-146004: fix test_args_from_interpreter_flags on windows (python#146580) pythongh-139003: Use frozenset for module level attributes in _pyrepl.utils (python#139004) pythonGH-146527: Add more data to GC statistics and add it to PyDebugOffsets (python#146532) ...
…ython#146577) The TypeError in _zstd_set_d_parameters incorrectly referred to compression options; say decompression options instead.
…ython#146577) The TypeError in _zstd_set_d_parameters incorrectly referred to compression options; say decompression options instead.
| Back | FazBrowse Home | New Git URL |
Summary
Fix the TypeError string in _zstd_set_d_parameters: it incorrectly said
compression options dictionary when validating decompression option keys.
Test plan
invalid key type to decompression options.