Repository navigation
gh-146609: Add colour to timeit CLI output - #146610
Merged
hugovk merged 9 commits intoApr 8, 2026
Merged
hugovk merged 9 commits into
hugovk merged 9 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Co-authored-by: Stan Ulbrych <stan@python.org>
StanFromIreland
approved these changes
Apr 7, 2026
Copy link
Copy Markdown
Contributor
|
Nitpick: I would segment this differently. The fact that the entire line after "raw times:" is just cyan is a wasted opportunity. Would make sense to me to make the commas delimiting the values be colored the same way as the arrows. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Like this? 
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Yes, that looks better to me! |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Thanks both for the reviews! |
Sorry, something went wrong.
This comment was marked as off-topic.
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
Co-authored-by: Stan Ulbrych <stan@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard and verbose:
With a warning:
./python.exe -m timeit "import time, random; time.sleep(random.random() * 0.9)"As usual, environment variables can control colour output.
📚 Documentation preview 📚: https://cpython-previews--146610.org.readthedocs.build/