Repository navigation
gh-146609: Use argparse for colour help timeit CLI - #149334
Merged
hugovk merged 2 commits intoMay 4, 2026
Merged
hugovk merged 2 commits into
hugovk merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
StanFromIreland
approved these changes
May 4, 2026
StanFromIreland
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
A few little suggestions.
Sorry, something went wrong.
Comment thread
Lib/timeit.py
Outdated
Comment thread
Misc/NEWS.d/next/Library/2026-05-03-23-47-59.gh-issue-146609.V9jqYf.rst
Outdated
Comment thread
Lib/timeit.py
Comment thread
Lib/timeit.py
Outdated
hugovk
commented
May 4, 2026
Co-authored-by: Stan Ulbrych <stan@python.org> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk
enabled auto-merge (squash)
May 4, 2026 08:17
Copy link
Copy Markdown
Member
Author
|
Thanks for the review! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #146610.
This not only gives us colour help, which is more readable, it improves validation.
We also don't need to show the class info in CLI help.