Repository navigation
gh-148211: decompose _POP_TOP_LOAD_CONST_INLINE(_BORROW) in JIT - #148230
Merged
Fidget-Spinner merged 4 commits intoApr 8, 2026
Merged
Fidget-Spinner merged 4 commits into
Fidget-Spinner merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
NekoAsakura
requested review from
Fidget-Spinner,
markshannon,
savannahostrowski and
tomasr8
as code owners
April 7, 2026 19:35
Copy link
Copy Markdown
Member
|
Feel free to remove the composite uops altogether, including removing them from remove_unneeded_uops! |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Ah wait, it seems this is quite hard to remove from the unneeded ops pass without modifying it heavily. So let's skip that for now. Thanks! |
Sorry, something went wrong.
Fidget-Spinner
approved these changes
Apr 7, 2026
Fidget-Spinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM. Thanks a lot!
Sorry, something went wrong.
Comment thread
Python/optimizer_analysis.c
Copy link
Copy Markdown
Member
|
Please fix the merge conflicts from the other PR. Thank you! |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Done :) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The composite uop definitions in bytecodes.c are kept for now — remove_unneeded_uops still produces them as intermediate forms during push/pop cancellation.
cpython/Python/optimizer_analysis.c
Lines 610 to 653 in 4ff8b07
Specifically, these composites chain through _POP_TOP_LOAD_CONST_INLINE_BORROW in the op_without_push / op_without_pop / op_without_pop_null tables:
Additionally, _LOAD_CONST_UNDER_INLINE(_BORROW) references _POP_TOP_LOAD_CONST_INLINE(_BORROW) as a target in op_without_push — those table entries would need updating too.
Once these dependents are decomposed, the definitions can be fully removed.