FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-148211: decompose `[_POP_CALL_X/_SHUFFLE_2]_LOAD_CONST_INLINE_BORROW` in JIT by NekoAsakura · Pull Request #148313 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-148211: decompose [_POP_CALL_X/_SHUFFLE_2]_LOAD_CONST_INLINE_BORROW in JIT - #148313

Merged
Fidget-Spinner merged 1 commit into
python:mainfrom
NekoAsakura:gh-148211/decompose-pop-call
Apr 10, 2026
ConversationCommits (1)ChecksFiles changed
Merged

gh-148211: decompose [_POP_CALL_X/_SHUFFLE_2]_LOAD_CONST_INLINE_BORROW in JIT#148313
Fidget-Spinner merged 1 commit into
python:mainfrom
NekoAsakura:gh-148211/decompose-pop-call

Conversation

NekoAsakura commented Apr 9, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Apr 9, 2026
Closed
Fidget-Spinner approved these changes Apr 9, 2026
View reviewed changes

Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Lines changed: 1040 additions & 1411 deletions

Now that's what I like to see!

Comment thread Python/optimizer_bytecodes.c
}
sym_set_const(res, out);
ADD_OP(_POP_CALL_TWO_LOAD_CONST_INLINE_BORROW, 0, (uintptr_t)out);
ADD_OP(_POP_CALL_TWO, 0, 0);

Fidget-Spinner Apr 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We should get rid of this into POP_TOP, POP_TOP, POP_TOP_NOP, POP_TOP in the next PR.

NekoAsakura Apr 9, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'd like to decompose _POP_TWO_LOAD_CONST_INLINE_BORROW and _INSERT_2_LOAD_CONST_INLINE_BORROW and get shot of _POP_TOP_LOAD_CONST_INLINE(_BORROW) we left in #148230 in the next PR. I'll sort _POP_CALL* into individual pops after that.

Fidget-Spinner Apr 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sounds good, thanks!

Fidget-Spinner merged commit aea0b91 into python:main Apr 10, 2026
82 checks passed
NekoAsakura deleted the gh-148211/decompose-pop-call branch April 10, 2026 13:57
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
pythongh-148211: decompose `[_POP_CALL_X/_SHUFFLE_2]_LOAD_CONST_INLIN…
c354488 
…E_BORROW` in JIT (pythonGH-148313)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Fidget-Spinner Fidget-Spinner approved these changes
markshannon Awaiting requested review from markshannon markshannon is a code owner
tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner
savannahostrowski Awaiting requested review from savannahostrowski

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL