FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-148352: Add more colour to `calendar` CLI output by hugovk · Pull Request #148354 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-148352: Add more colour to calendar CLI output - #148354

Merged
hugovk merged 10 commits into
python:mainfrom
hugovk:3.15-calendar-colour
May 4, 2026
ConversationCommits (10)ChecksFiles changed
Merged

gh-148352: Add more colour to calendar CLI output#148354
hugovk merged 10 commits into
python:mainfrom
hugovk:3.15-calendar-colour

Conversation

hugovk commented Apr 10, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

In Python 3.14, we added an amazing colour highlight for today: #128318.

Let's add a touch more colour.

Before After

📚 Documentation preview 📚: https://cpython-previews--148354.org.readthedocs.build/

hugovk requested a review from AA-Turner as a code owner April 10, 2026 17:27
hugovk added the stdlib Standard Library Python modules in the Lib/ directory label Apr 10, 2026
bedevere-app Bot mentioned this pull request Apr 10, 2026
Closed
sharktide reviewed Apr 10, 2026
View reviewed changes
Comment thread Doc/library/calendar.rst Outdated
Improve docs
4b202f0 
Co-authored-by: Rihaan Meher <sharktidedev@gmail.com>
sharktide reviewed Apr 10, 2026
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2026-04-10-20-23-22.gh-issue-148352.lrec3W.rst Outdated
Comment thread Lib/calendar.py

This comment was marked as resolved.

Sign in to view
Update NEWS
cab1a52 
Co-authored-by: Rihaan Meher <sharktidedev@gmail.com>
sharktide reviewed Apr 11, 2026
View reviewed changes

sharktide left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks @hugovk :)

johnslavik self-requested a review April 14, 2026 23:52
hugovk mentioned this pull request Apr 26, 2026
Closed
StanFromIreland reviewed May 4, 2026
View reviewed changes
Comment thread Lib/test/test_calendar.py Outdated
@@ -1122,4 +1123,4 @@
self.assertCmdFails(*args)

@support.force_not_colorized

StanFromIreland May 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can be removed, no?

hugovk May 4, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Removed!

Comment thread Lib/test/test_calendar.py
self.assertCmdFails(*args)

@support.force_not_colorized
def test_help(self):

StanFromIreland May 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can we also have a case checking for color?

hugovk May 4, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Added!

read-the-docs-community Bot commented May 4, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #32524822 | 📁 Comparing ca4ab58 against main (1e7dfbc)

  🔍 Preview build  

52 files changed · + 1 added · ± 51 modified

+ Added

± Modified

StanFromIreland reviewed May 4, 2026
View reviewed changes
Comment thread Lib/test/test_calendar.py
today = datetime.date(2026, 5, 4)
cal = calendar._CLIDemoCalendar(highlight_day=today)
output = cal.formatmonth(2026, 5)
self.assertIn("\x1b[30m\x1b[43mMay 2026\x1b[0m\n\x1b[36m", output)

StanFromIreland May 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hmm, do we support running tests with different themes? If a user has a custom theme this test will fail.

hugovk May 4, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We don't support running tests with different themes.

Other tests could also break if the user changed the theme:

❯ rg "x1b" Lib/test/test_*.py -l | wc -l
      13

Right now the theme API is internal/private. If we make it public in a later release, we'll need to consider tests are with the default theme or a specific theme.

StanFromIreland approved these changes May 4, 2026
View reviewed changes

StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM :-) 🌈

hugovk merged commit 2ba0a81 into python:main May 4, 2026
64 checks passed
hugovk deleted the 3.15-calendar-colour branch May 4, 2026 12:15

hugovk commented May 4, 2026

Copy link
Copy Markdown
Member Author

Thanks @sharktide and @StanFromIreland for the reviews!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

StanFromIreland StanFromIreland approved these changes
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
johnslavik Awaiting requested review from johnslavik
+1 more reviewer
sharktide sharktide left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

stdlib Standard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL