FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-149879: Fix test_httpservers on Cygwin by vstinner · Pull Request #150417 · python/cpython · GitHub

Repository navigation

gh-149879: Fix test_httpservers on Cygwin - #150417

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:test_httpservers
May 25, 2026
Merged

vstinner merged 1 commit into
python:mainfrom
vstinner:test_httpservers

Conversation

vstinner commented May 25, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels May 25, 2026
bedevere-app Bot mentioned this pull request May 25, 2026

Copy link
Copy Markdown
Member Author

BaseHTTPSServerTestCase and test_https_client() still fail with this PR. But I propose disabling the ssl module on Cygwin for now, since many tests are failing.

Copy link
Copy Markdown
Member Author

BaseHTTPSServerTestCase and test_https_client() still fail with this PR. But I propose disabling the ssl module on Cygwin for now, since many tests are failing.

These tests pass with the ssl PR gh-150419.

picnixz commented May 25, 2026

Copy link
Copy Markdown
Member

But I propose disabling the ssl module on Cygwin for now, since many tests are failing.

Disabling it seems a good way to fix the problems indeed. We need to investigate more the reason why SSL on cygwin is struggling before fixing each test one by one (I prefer having the big picture first because we may introduce subtle issues if we do a case-by-case)

Copy link
Copy Markdown
Member Author

Disabling it seems a good way to fix the problems indeed. We need to investigate more the reason why SSL on cygwin is struggling before fixing each test one by one (I prefer having the big picture first because we may introduce subtle issues if we do a case-by-case)

I changed my mind. It's no longer needed to disable the ssl module, since I have a working fix for ssl on Cygwin: PR gh-150419.

vstinner enabled auto-merge (squash) May 25, 2026 19:41
vstinner merged commit 71fa314 into python:main May 25, 2026
95 of 97 checks passed
vstinner deleted the test_httpservers branch May 25, 2026 19:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL