Repository navigation
gh-133031: Fix test_textbox_edit_wide on a narrow build - #152592
Merged
serhiy-storchaka merged 1 commit intoJun 29, 2026
Merged
serhiy-storchaka merged 1 commit into
serhiy-storchaka merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
unget_wch() can push only a single-byte character on a narrow build, so skip the multi-byte cases there. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_textbox_edit_wide is the only textbox test that feeds characters through curses.unget_wch(). On a narrow build (no wide-character support) unget_wch() can only push a character that encodes to a single byte, so under a UTF-8 locale a non-ASCII character such as 'é' raises OverflowError. This was failing on the macOS buildbots, which link the system narrow curses.
Skip the multi-byte cases on a narrow build, the same way the existing 8-bit textbox tests do.