Repository navigation
gh-133031: Fix test_textbox_unicode on a narrow build - #152750
Merged
serhiy-storchaka merged 1 commit intoJul 1, 2026
Merged
serhiy-storchaka merged 1 commit into
serhiy-storchaka merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
A narrow build stores one byte per cell, so skip the multi-byte cases there, as already done for test_textbox_edit_wide. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_textbox_unicode and test_textbox_unicode_insert_mode (added by GH-152482) guarded only on _encodable(), so under a UTF-8 locale on a narrow build they fed multi-byte characters to do_command(), where addch() raises OverflowError: byte doesn't fit in chtype (a narrow build stores one byte per cell).
Skip the multi-byte cases on a narrow build, as already done for test_textbox_edit_wide in GH-152592.
Reproduced the failure (10 errors) and confirmed the fix on a narrow _curses build under a UTF-8 locale; no change on a wide build.