FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-69134: Wait until mapped in SimpleDialog keyboard tests by serhiy-storchaka · Pull Request #152690 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-69134: Wait until mapped in SimpleDialog keyboard tests - #152690

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:gh-69134-map-simpledialog-tests
Jul 5, 2026
ConversationCommits (1)ChecksFiles changed
Merged

gh-69134: Wait until mapped in SimpleDialog keyboard tests#152690
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:gh-69134-map-simpledialog-tests

Conversation

serhiy-storchaka commented Jun 30, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

The SimpleDialog tests generate key events after focus_force(). On Windows these are only delivered once the toplevel is mapped, so they could be dropped and the test fail intermittently — seen on the AMD64 Windows10 buildbot, where test_return_no_default failed on the first run and passed on the re-run.

Unlike the query dialogs (whose __init__ calls wait_visibility()), SimpleDialog only waits for its window in go(), which these tests bypass. Wait until the window is mapped in the create() helper, as GH-152599 did for the other keyboard tests.

bedevere-app Bot added the tests Tests in the Lib/test dir label Jun 30, 2026
bedevere-app Bot mentioned this pull request Jun 30, 2026
Closed
serhiy-storchaka force-pushed the gh-69134-map-simpledialog-tests branch from 9fb01c8 to 99cf022 Compare June 30, 2026 14:19
pythongh-69134: Wait until mapped in SimpleDialog keyboard tests
1b5a7b2 
The SimpleDialog keyboard tests generate key events after focus_force(),
which on Windows are dropped until the toplevel is mapped, so they could
fail intermittently (seen on the Windows10 buildbot as
test_return_no_default).  Wait until the window is mapped in each of
these tests, as pythonGH-152599 did for the other keyboard tests.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka force-pushed the gh-69134-map-simpledialog-tests branch from 99cf022 to 1b5a7b2 Compare June 30, 2026 16:06
serhiy-storchaka added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 30, 2026

bedevere-bot commented Jun 30, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 1b5a7b2 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F152690%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 30, 2026
serhiy-storchaka merged commit 7d619c2 into python:main Jul 5, 2026
140 of 145 checks passed
serhiy-storchaka deleted the gh-69134-map-simpledialog-tests branch July 5, 2026 10:51
serhiy-storchaka added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Jul 5, 2026

miss-islington-app Bot commented Jul 5, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented Jul 5, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington-app Bot commented Jul 5, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

miss-islington-app Bot commented Jul 5, 2026

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7d619c2fea131722d0bfdad150c081c44cc0abd7 3.13

miss-islington-app Bot commented Jul 5, 2026

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7d619c2fea131722d0bfdad150c081c44cc0abd7 3.14

miss-islington-app Bot commented Jul 5, 2026

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.15 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7d619c2fea131722d0bfdad150c081c44cc0abd7 3.15

serhiy-storchaka mentioned this pull request Jul 5, 2026
Merged

bedevere-app Bot commented Jul 5, 2026

Copy link
Copy Markdown

GH-153104 is a backport of this pull request to the 3.15 branch.

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Jul 5, 2026
serhiy-storchaka mentioned this pull request Jul 5, 2026
Merged

bedevere-app Bot commented Jul 5, 2026

Copy link
Copy Markdown

GH-153105 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 5, 2026
serhiy-storchaka mentioned this pull request Jul 5, 2026
Merged

bedevere-app Bot commented Jul 5, 2026

Copy link
Copy Markdown

GH-153106 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 5, 2026
serhiy-storchaka added a commit that referenced this pull request Jul 5, 2026
[3.13] gh-69134: Wait until mapped in SimpleDialog keyboard tests (GH…
18735fd 
…-152690) (GH-153106)

The SimpleDialog keyboard tests generate key events after focus_force(),
which on Windows are dropped until the toplevel is mapped, so they could
fail intermittently (seen on the Windows10 buildbot as
test_return_no_default).  Wait until the window is mapped in these tests,
as GH-152599 did for the other keyboard tests.

(cherry picked from commit 7d619c2)

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka added a commit that referenced this pull request Jul 5, 2026
[3.14] gh-69134: Wait until mapped in SimpleDialog keyboard tests (GH…
8486016 
…-152690) (GH-153105)

The SimpleDialog keyboard tests generate key events after focus_force(),
which on Windows are dropped until the toplevel is mapped, so they could
fail intermittently (seen on the Windows10 buildbot as
test_return_no_default).  Wait until the window is mapped in these tests,
as GH-152599 did for the other keyboard tests.

(cherry picked from commit 7d619c2)

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka added a commit that referenced this pull request Jul 5, 2026
[3.15] gh-69134: Wait until mapped in SimpleDialog keyboard tests (GH…
0416fcd 
…-152690) (GH-153104)

The SimpleDialog keyboard tests generate key events after focus_force(),
which on Windows are dropped until the toplevel is mapped, so they could
fail intermittently (seen on the Windows10 buildbot as
test_return_no_default).  Wait until the window is mapped in these tests,
as GH-152599 did for the other keyboard tests.

(cherry picked from commit 7d619c2)

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka removed their assignment Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL