Repository navigation
[3.13] gh-69134: Wait until mapped in SimpleDialog keyboard tests (GH-152690) - #153106
Merged
serhiy-storchaka merged 1 commit intoJul 5, 2026
Merged
serhiy-storchaka merged 1 commit into
serhiy-storchaka merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…ts (pythonGH-152690) The SimpleDialog keyboard tests generate key events after focus_force(), which on Windows are dropped until the toplevel is mapped, so they could fail intermittently (seen on the Windows10 buildbot as test_return_no_default). Wait until the window is mapped in these tests, as pythonGH-152599 did for the other keyboard tests. (cherry picked from commit 7d619c2) Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Copy link
Copy Markdown
Documentation build overview465 files changed · + 1 added · ± 424 modified · - 40 deleted + Added ± Modified
- Deleted |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #152690 (miss-islington could not backport it automatically).
The SimpleDialog ttk modernization is not on 3.13, so only two of the keyboard tests it touched exist here — test_return_activates_default and test_return_no_default (the buildbot flake). This adds the mapped-wait to those two.