Repository navigation
gh-66172: Don't let a corrupt config file prevent IDLE from starting - #152764
Merged
terryjreedy merged 2 commits intoSep 13, 2026
Merged
terryjreedy merged 2 commits into
terryjreedy merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…rting If a user configuration file cannot be read, rename it with a ".bad" suffix, use default settings, and warn the user with a message box.
serhiy-storchaka
force-pushed
the
gh-66172-corrupt-config
branch
from
23f16c7 to
8e989e9
Compare
July 1, 2026 10:23
terryjreedy
previously requested changes
Sep 13, 2026
terryjreedy
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nice fix. Approved either as is or with preferred changes.
Sorry, something went wrong.
Comment thread
Lib/idlelib/idle_test/test_config.py
Outdated
Comment on lines
+315
to
+316
| def test_load_cfg_files_bad(self): | ||
| # gh-66172: an unparsable user file is renamed, not fatal, not lost. |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This better describes what gets tested.
Suggested change
| def test_load_cfg_files_bad(self): | |
| # gh-66172: an unparsable user file is renamed, not fatal, not lost. | |
| def test_load_cfg_files_bad_format(self): | |
| # gh-66172: rename an unparsable user file and save the exception. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
done
Sorry, something went wrong.
Comment thread
Lib/idlelib/pyshell.py
Comment thread
Lib/idlelib/idle_test/test_config.py
Outdated
Copy link
Copy Markdown
|
When you're done making the requested changes, leave the comment: I have made the requested changes; please review again. |
Sorry, something went wrong.
Say in the name of the test what it tests, and name the path after the file it points to, not after the state of that file. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Copy link
Copy Markdown
|
Thanks @serhiy-storchaka for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-157458 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-157459 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-157460 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
terryjreedy
pushed a commit
that referenced
this pull request
Sep 13, 2026
…arting (GH-152764) (#157460) gh-66172: Don't let a corrupt config file prevent IDLE from starting (GH-152764) If a user configuration file cannot be read, because of either bad unicode or configuration, rename it with a ".bad" suffix, use default settings, and warn the user with a message box. --------- (cherry picked from commit ae0d6cc) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
terryjreedy
pushed a commit
that referenced
this pull request
Sep 13, 2026
…arting (GH-152764) (#157459) gh-66172: Don't let a corrupt config file prevent IDLE from starting (GH-152764) If a user configuration file cannot be read, because of either bad unicode or configuration, rename it with a ".bad" suffix, use default settings, and warn the user with a message box. --------- (cherry picked from commit ae0d6cc) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
johnslavik
pushed a commit
to johnslavik/cpython
that referenced
this pull request
Sep 14, 2026
…rting (python#152764) If a user configuration file cannot be read, because of either bad unicode or configuration, rename it with a ".bad" suffix, use default settings, and warn the user with a message box. --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This was referenced Sep 15, 2026
terryjreedy
pushed a commit
that referenced
this pull request
Oct 9, 2026
…arting (GH-152764) (#157458) gh-66172: Don't let a corrupt config file prevent IDLE from starting (GH-152764) If a user configuration file cannot be read, because of either bad unicode or configuration, rename it with a ".bad" suffix, use default settings, and warn the user with a message box. --------- (cherry picked from commit ae0d6cc) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IDLE crashed at startup if a user configuration file could not be read — for example, a hand-edited config-extensions.cfg missing a section header (configparser.MissingSectionHeaderError), or a file that is not valid UTF-8. The file is read at import time, before any Tk root exists, which is why the error could not previously be shown in a message box (and printing to the console is invisible under pythonw).
Now the unreadable user file is renamed with a .bad suffix — so the user's file is preserved rather than overwritten or deleted when settings are next saved — IDLE continues with default settings, and main() shows a warning listing the affected files once the root is up. A corrupt shipped default file is left to surface as before, since that indicates a broken installation rather than user data.
This also removes the errors='replace' added to Load() in gh-85320: silently replacing undecodable bytes with U+FFFD mangled the values (and could be written back on the next save, making the corruption permanent). Letting the UnicodeDecodeError propagate and be handled the same way as a parse error is non-destructive and recoverable. Both changes target the same backport branches, so there is no version skew.