Repository navigation
gh-153477: Fix IDLE startup crash on a corrupt user config file - #153478
Closed
tonghuaroot wants to merge 2 commits into
Closed
tonghuaroot wants to merge 2 commits into
tonghuaroot wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
IdleConfParser.Load raised the configparser exception on a corrupt or partially written user configuration file, which aborted IDLE startup. Catch it, warn, and fall back to the default configuration, matching the module's documented graceful-degradation behavior.
Wulian233
reviewed
Jul 10, 2026
Comment thread
Lib/idlelib/idle_test/test_config.py
Outdated
| self.assertEqual(parser.GetOptionList('Foo Bar'), ['foo']) | ||
|
|
||
| def test_load_invalid_file(self): | ||
| # gh-000000: a corrupt config file must warn and fall back to |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Suggested change
| # gh-000000: a corrupt config file must warn and fall back to | |
| # gh-153478: a corrupt config file must warn and fall back to |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Thanks, fixed in 0a94b48. Used the issue number gh-153477 to match the commit subject and the NEWS entry.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IdleConfParser.Load called configparser's read_file with no error handling, so a corrupt or partially written user configuration file (for example one left behind by an interrupted Save) raised a configparser.Error such as MissingSectionHeaderError and aborted IDLE startup. This contradicts the graceful-degradation behavior documented in the config.py module docstring.
Load now catches configparser.Error, warns to stderr, and falls back to the default configuration. The regression test writes a headerless config file and checks that Load warns and leaves the parser empty instead of raising.