FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-153133: Fix socket leak in asyncio create_connection by deadlovelll · Pull Request #153134 · python/cpython · GitHub

/ cpython Public

gh-153133: Fix socket leak in asyncio create_connection - #153134

Merged
kumaraditya303 merged 2 commits into
python:mainfrom
deadlovelll:gh-153133-socket-leak
Jul 7, 2026
ConversationCommits (2)ChecksFiles changed
Merged

gh-153133: Fix socket leak in asyncio create_connection#153134
kumaraditya303 merged 2 commits into
python:mainfrom
deadlovelll:gh-153133-socket-leak

Conversation

deadlovelll commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Close the socket in _create_connection_transport() when the transport is never created, not only on await failure

For more details see gh-153133

bedevere-app Bot mentioned this pull request Jul 5, 2026
Closed
kumaraditya303 reviewed Jul 7, 2026
View reviewed changes
Comment thread Lib/asyncio/base_events.py Outdated
kumaraditya303 merged commit 374920a into python:main Jul 7, 2026
55 checks passed
kumaraditya303 added topic-asyncio needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jul 24, 2026

miss-islington-app Bot commented Jul 24, 2026

Copy link
Copy Markdown

Thanks @deadlovelll for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

miss-islington-app Bot commented Jul 24, 2026

Copy link
Copy Markdown

Thanks @deadlovelll for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington-app Bot commented Jul 24, 2026

Copy link
Copy Markdown

Sorry, @deadlovelll and @kumaraditya303, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 374920a23d49130f446fe6369220bc548be57cd2 3.14

bedevere-app Bot commented Jul 24, 2026

Copy link
Copy Markdown

GH-154631 is a backport of this pull request to the 3.15 branch.

bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 24, 2026
kumaraditya303 pushed a commit that referenced this pull request Jul 25, 2026
[3.15] gh-153133: Fix socket leak in error path of asyncio create_con…
b4d0b26 
…nection (GH-153134) (#154631)

gh-153133: Fix socket leak in error path of asyncio create_connection (GH-153134)
(cherry picked from commit 374920a)

Co-authored-by: Timofei <128279579+deadlovelll@users.noreply.github.com>

hugovk commented Jul 29, 2026

Copy link
Copy Markdown
Member

@deadlovelll Would you like to have a go at the backports?

deadlovelll commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@deadlovelll Would you like to have a go at the backports?

Yes, of course, I'll take a look sometime today

deadlovelll mentioned this pull request Jul 29, 2026
Merged

bedevere-app Bot commented Jul 29, 2026

Copy link
Copy Markdown

GH-154897 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 29, 2026

deadlovelll commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@hugovk hello! Just created #154897

kumaraditya303 pushed a commit that referenced this pull request Aug 5, 2026
[3.14] gh-153133: Fix socket leak in error path of asyncio create_con…
162bd7e 
…nection (GH-153134) (#154897)
This was referenced Aug 17, 2026
Open
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kumaraditya303 kumaraditya303 approved these changes
1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
willingc Awaiting requested review from willingc willingc is a code owner

Assignees

kumaraditya303

Labels

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL