gh-155934: Fix socket leak and silent error for asyncio accepted connections - #155936
Merged
kumaraditya303 merged 3 commits intoAug 23, 2026
Merged
gh-155934: Fix socket leak and silent error for asyncio accepted connections#155936kumaraditya303 merged 3 commits into
kumaraditya303 merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
danielKim614
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
August 17, 2026 06:11
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
kumaraditya303
approved these changes
Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When protocol_factory() or transport creation raises for an accepted connection in BaseSelectorEventLoop._accept_connection2(), close the accepted socket (it would otherwise leak until garbage collection) and report the error via the loop exception handler even when debug mode is disabled.
Reporting stays debug-only once the transport exists, so await waiter failures such as SSL handshake errors from port scanners are not reported unconditionally.
This is the server-side counterpart of gh-153134 (GH-153133).
The new tests fail without the fix and pass with it. The full test_asyncio suite passes, including -R 3:3 refleak runs on test_selector_events.
cc. Pycon 2026 KR Sprint @hugovk @corona10