Repository navigation
gh-153621: Expose raw libzstd error code in ZstdError messages - #153641
Open
su-213 wants to merge 4 commits into
Open
su-213 wants to merge 4 commits into
su-213 wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Include the raw error code returned by libzstd in all ZstdError messages, making it easier for users to diagnose compression and decompression issues.
Copy link
Copy Markdown
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Hi @su-213 could you please add a NEWS entry? |
Sorry, something went wrong.
emmatyping
reviewed
Oct 23, 2026
Comment thread
Misc/NEWS.d/next/Library/2026-07-22-12-56-25.gh-issue-153621.0dccf5c6.rst
Outdated
emmatyping
reviewed
Oct 23, 2026
Comment thread
Modules/_zstd/_zstdmodule.c
| switch (type) { | ||
| case ERR_DECOMPRESS: | ||
| msg = "Unable to decompress Zstandard data: %s"; | ||
| msg = "Unable to decompress Zstandard data: %s (error code %llu)"; |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
To match OSError, can you format the code before the message please?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include the raw error code returned by libzstd in all ZstdError messages, making it easier for users to diagnose compression and decompression issues.
Include the raw error code returned by libzstd in all ZstdError messages, making it easier for users to diagnose compression and decompression issues.
Closes #153621