FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-153621: Expose raw libzstd error code in `ZstdError` messages by su-213 · Pull Request #153641 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-153621: Expose raw libzstd error code in ZstdError messages #153641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
su-213 wants to merge 4 commits into
base: main
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 5 Commits 4 Checks 52 Files changed
Open

gh-153621: Expose raw libzstd error code in ZstdError messages #153641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
21812d5
gh-153621: Expose raw libzstd error code in ZstdError messages
su-213 Jul 13, 2026
72c182a
Add NEWS entry for gh-153621
su-213 Jul 22, 2026
3d74a3b
Merge branch 'main' into zstd-error-code
emmatyping Oct 22, 2026
8b4bed3
Qualify ZstdError in NEWS
emmatyping Oct 23, 2026
File filter

Filter by extension

Filter by extension .c  (1) .rst  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2026-07-22-12-56-25.gh-issue-153621.0dccf5c6.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Include the raw libzstd error code in all :exc:`~compression.zstd.ZstdError` messages, making
it easier for users to diagnose compression and decompression failures.
29 changes: 18 additions & 11 deletions Modules/_zstd/_zstdmodule.c
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -67,45 +67,52 @@ set_zstd_error(const _zstd_state *state, error_type type, size_t zstd_ret)
}
switch (type) {
case ERR_DECOMPRESS:
msg = "Unable to decompress Zstandard data: %s";
msg = "Unable to decompress Zstandard data: %s (error code %llu)";

emmatyping Oct 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

To match OSError, can you format the code before the message please?
break;
case ERR_COMPRESS:
msg = "Unable to compress Zstandard data: %s";
msg = "Unable to compress Zstandard data: %s (error code %llu)";
break;
case ERR_SET_PLEDGED_INPUT_SIZE:
msg = "Unable to set pledged uncompressed content size: %s";
msg = "Unable to set pledged uncompressed content size: %s "
"(error code %llu)";
break;

case ERR_LOAD_D_DICT:
msg = "Unable to load Zstandard dictionary or prefix for "
"decompression: %s";
"decompression: %s (error code %llu)";
break;
case ERR_LOAD_C_DICT:
msg = "Unable to load Zstandard dictionary or prefix for "
"compression: %s";
"compression: %s (error code %llu)";
break;

case ERR_GET_C_BOUNDS:
msg = "Unable to get zstd compression parameter bounds: %s";
msg = "Unable to get zstd compression parameter bounds: %s "
"(error code %llu)";
break;
case ERR_GET_D_BOUNDS:
msg = "Unable to get zstd decompression parameter bounds: %s";
msg = "Unable to get zstd decompression parameter bounds: %s "
"(error code %llu)";
break;
case ERR_SET_C_LEVEL:
msg = "Unable to set zstd compression level: %s";
msg = "Unable to set zstd compression level: %s "
"(error code %llu)";
break;

case ERR_TRAIN_DICT:
msg = "Unable to train the Zstandard dictionary: %s";
msg = "Unable to train the Zstandard dictionary: %s "
"(error code %llu)";
break;
case ERR_FINALIZE_DICT:
msg = "Unable to finalize the Zstandard dictionary: %s";
msg = "Unable to finalize the Zstandard dictionary: %s "
"(error code %llu)";
break;

default:
Py_UNREACHABLE();
}
PyErr_Format(state->ZstdError, msg, ZSTD_getErrorName(zstd_ret));
PyErr_Format(state->ZstdError, msg, ZSTD_getErrorName(zstd_ret),
(unsigned long long)zstd_ret);
}

typedef struct {
Expand Down
Loading
Back | FazBrowse Home | New Git URL