FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-154948: Fix `test_zipfile` failure when `SOURCE_DATE_EPOCH` is set by StanFromIreland · Pull Request #155001 · python/cpython · GitHub

/ cpython Public

gh-154948: Fix test_zipfile failure when SOURCE_DATE_EPOCH is set - #155001

Merged
StanFromIreland merged 2 commits into
python:mainfrom
StanFromIreland:SOURCE_DATE_EPOCH
Aug 7, 2026
ConversationCommits (2)ChecksFiles changed
Merged

gh-154948: Fix test_zipfile failure when SOURCE_DATE_EPOCH is set#155001
StanFromIreland merged 2 commits into
python:mainfrom
StanFromIreland:SOURCE_DATE_EPOCH

Conversation

StanFromIreland commented Jul 31, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Additionally, move the SOURCE_DATE_EPOCH test helpers from test_py_compile to test.support.os_helper, and refactor a little in test_zipfile and test_random to use them instead of duplicate helpers (they were already used by test_importlib and test_compileall).

Fix test_zipfile failure when SOURCE_DATE_EPOCH is set
0432647 
Additionally, move the `SOURCE_DATE_EPOCH` test helpers from `test_py_compile` to `test.support.os_helper`.
StanFromIreland added the tests Tests in the Lib/test dir label Jul 31, 2026
bedevere-app Bot mentioned this pull request Jul 31, 2026
Closed

StanFromIreland commented Jul 31, 2026

Copy link
Copy Markdown
Member Author

CC @vstinner, as you added them a little while ago in #9607.

read-the-docs-community Bot commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33960581 | 📁 Comparing f189a89 against main (a646c99)

  🔍 Preview build  

18 files changed · ± 18 modified

± Modified

vstinner reviewed Aug 7, 2026
View reviewed changes
Comment thread Lib/test/test_zipfile/test_core.py
vstinner approved these changes Aug 7, 2026
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

StanFromIreland merged commit 82905dd into python:main Aug 7, 2026
54 checks passed
StanFromIreland deleted the SOURCE_DATE_EPOCH branch August 7, 2026 14:21
StanFromIreland added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Aug 7, 2026

miss-islington-app Bot commented Aug 7, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington-app Bot commented Aug 7, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented Aug 7, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

miss-islington-app Bot commented Aug 7, 2026

Copy link
Copy Markdown

Sorry, @StanFromIreland, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 82905dd165f198f1b18625ae0f0ede9367df75a4 3.14

miss-islington-app Bot commented Aug 7, 2026

Copy link
Copy Markdown

Sorry, @StanFromIreland, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 82905dd165f198f1b18625ae0f0ede9367df75a4 3.13

miss-islington-app Bot commented Aug 7, 2026

Copy link
Copy Markdown

Sorry, @StanFromIreland, I could not cleanly backport this to 3.15 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 82905dd165f198f1b18625ae0f0ede9367df75a4 3.15

bedevere-app Bot commented Aug 7, 2026

Copy link
Copy Markdown

GH-155347 is a backport of this pull request to the 3.15 branch.

bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Aug 7, 2026
hugovk pushed a commit that referenced this pull request Aug 7, 2026
[3.15] gh-154948: Fix test_zipfile failure when SOURCE_DATE_EPOCH…
c56ce5a 
… is set (GH-155001) (#155347)
StanFromIreland removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Aug 7, 2026
mbeijen pushed a commit to mbeijen/cpython that referenced this pull request Aug 14, 2026
pythongh-154948: Fix test_zipfile failure when SOURCE_DATE_EPOCH …
acc625f 
…is set (python#155001)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
warsaw Awaiting requested review from warsaw warsaw is a code owner
FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Assignees

StanFromIreland

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL