FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.15] gh-154948: Fix `test_zipfile` failure when `SOURCE_DATE_EPOCH` is set (GH-155001) by StanFromIreland · Pull Request #155347 · python/cpython · GitHub

/ cpython Public

[3.15] gh-154948: Fix test_zipfile failure when SOURCE_DATE_EPOCH is set (GH-155001) - #155347

Merged
hugovk merged 1 commit into
python:3.15from
StanFromIreland:backport-82905dd-3.15
Aug 7, 2026
ConversationCommits (1)ChecksFiles changed
Merged

[3.15] gh-154948: Fix test_zipfile failure when SOURCE_DATE_EPOCH is set (GH-155001)#155347
hugovk merged 1 commit into
python:3.15from
StanFromIreland:backport-82905dd-3.15

Conversation

StanFromIreland commented Aug 7, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

[3.15] pythongh-154948: Fix test_zipfile failure when `SOURCE_DATE_…
0905924 
…EPOCH` is set (pythonGH-155001)

(cherry picked from commit 82905dd)

Co-authored-by: Stan Ulbrych <stan@python.org>
bedevere-app Bot mentioned this pull request Aug 7, 2026
Closed
bedevere-app Bot mentioned this pull request Aug 7, 2026
Merged

read-the-docs-community Bot commented Aug 7, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33961774 | 📁 Comparing 0905924 against main (82905dd)

  🔍 Preview build  

294 files changed · + 1 added · ± 289 modified · - 4 deleted

+ Added

± Modified

- Deleted

StanFromIreland marked this pull request as ready for review August 7, 2026 15:05
vstinner approved these changes Aug 7, 2026
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. This fix can wait for Python 3.15.1.

StanFromIreland commented Aug 7, 2026

Copy link
Copy Markdown
Member Author

This fix can wait for Python 3.15.1.

These are just changes to tests, so I assume they won't be an issue?

vstinner commented Aug 7, 2026

Copy link
Copy Markdown
Member

@StanFromIreland StanFromIreland assigned hugovk

As I wrote, I think that this change can wait for Python 3.15.1. No need to rush a fix in Python 3.15.0.

hugovk commented Aug 7, 2026

Copy link
Copy Markdown
Member

Tests can generally go in, they help improve the quality. 👍

hugovk merged commit c56ce5a into python:3.15 Aug 7, 2026
61 checks passed
StanFromIreland deleted the backport-82905dd-3.15 branch August 7, 2026 17:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
warsaw Awaiting requested review from warsaw warsaw is a code owner
FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Assignees

hugovk

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL