FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.13] gh-146004: fix test_args_from_interpreter_flags on windows (GH-146580) by miss-islington · Pull Request #155965 · python/cpython · GitHub

Repository navigation

[3.13] gh-146004: fix test_args_from_interpreter_flags on windows (GH-146580) - #155965

Merged
zware merged 1 commit into
python:3.13from
miss-islington:backport-1af025d-3.13
Aug 18, 2026
Merged

zware merged 1 commit into
python:3.13from
miss-islington:backport-1af025d-3.13

Conversation

miss-islington commented Aug 17, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

…honGH-146580)

(cherry picked from commit 1af025d)

Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>

gpshead commented Aug 17, 2026

Copy link
Copy Markdown
Member

!buildbot .win.

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @gpshead for commit e0125f6 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F155965%2Fmerge

The command will test the builders whose names match following regular expression: .*win.*

The builders matched are:

  • ARM64 Windows PR
  • AMD64 Windows PGO Tailcall PR
  • AMD64 Windows11 Non-Debug PR
  • ARM64 Windows Non-Debug PR
  • AMD64 Windows10 PR
  • AMD64 Windows Server 2025 Refleaks PR
  • AMD64 Windows Server 2022 NoGIL PR
  • AMD64 Windows PGO NoGIL Tailcall PR
  • AMD64 Windows PGO PR
  • AMD64 Windows Server 2025 Clang PR
  • AMD64 Windows PGO NoGIL PR

Copy link
Copy Markdown
Member

This is good to merge IMHO:

  • I've tested locally before doing the backport
  • the failing buildbots are unrelated:
    • tail-calling isn't supported on Windows before 3.15. I don't know why the PR workers were triggered, maybe because branches={MAIN_BRANCH, PR_BRANCH}). IMHO, it should build on main and 3.15, and for PRs against those two branches.
    • the clang-cl failure is known on older branches: the fix did not get backported that far, hence Windows64ClangBuild has BRANCHES.only_since(3, 14). Furthermore, the new Windows clang-cl buildbots from @zware have tags={UNSTABLE, NO_TIER}. I just don't know why it triggered for a 3.13 PR ...

chris-eibl commented Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • branches={MAIN_BRANCH, PR_BRANCH}). IMHO, it should build on main and 3.15, and for PRs against those two branches.

@zware: would branches={BRANCHES.only_since(3, 15), PR_BRANCH.only_since(3, 15)} work?

zware commented Aug 18, 2026

Copy link
Copy Markdown
Member

See python/buildmaster-config#654; we don't currently have a way to restrict PR builders to particular base branches as we don't currently detect the base branch of a PR at all.

Copy link
Copy Markdown
Member

Thanks for the linked issue @zware ❤️

Seems that PR triggers are not easy to tackle, but IIUC, I've just stumbled over that we are missing a Windows tailcall bot for 3.15? I think changing to branches={BRANCHES.only_since(3, 15), PR_BRANCH} will fix that?

zware merged commit 2143dcd into python:3.13 Aug 18, 2026
52 of 55 checks passed
miss-islington deleted the backport-1af025d-3.13 branch August 18, 2026 22:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL