FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-63882: Implement empty tests in test_minidom by serhiy-storchaka · Pull Request #156677 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-63882: Implement empty tests in test_minidom - #156677

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:gh-63882-empty-tests
Sep 13, 2026
ConversationCommits (1)ChecksFiles changed
Merged

gh-63882: Implement empty tests in test_minidom#156677
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:gh-63882-empty-tests

Conversation

serhiy-storchaka commented Aug 30, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

The 25 tests defined as def testX(self): pass now test NamedNodeMap methods, the factory methods for namespaced nodes, parsing of elements, attributes, namespaces and processing instructions, and the traversal attributes.

testParse and testParseProcessingInstructions are limited to what is not already covered by testParseFromBinaryFile, testParseFromTextFile and testProcessingInstruction.

This makes PR #128948, which comments these tests out, unnecessary.

pythongh-63882: Implement empty tests in test_minidom
337ae51 
25 tests were defined as "def testX(self): pass" and reported success
without testing anything.
bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels Aug 30, 2026
bedevere-app Bot mentioned this pull request Aug 30, 2026
Closed
serhiy-storchaka mentioned this pull request Aug 30, 2026
Closed
aisk added the skip news label Aug 31, 2026
serhiy-storchaka merged commit f154574 into python:main Sep 13, 2026
54 checks passed
serhiy-storchaka deleted the gh-63882-empty-tests branch September 13, 2026 12:53
serhiy-storchaka added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Sep 13, 2026

miss-islington-app Bot commented Sep 13, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented Sep 13, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington-app Bot commented Sep 13, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

bedevere-app Bot commented Sep 13, 2026

Copy link
Copy Markdown

GH-157426 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Sep 13, 2026

bedevere-app Bot commented Sep 13, 2026

Copy link
Copy Markdown

GH-157427 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Sep 13, 2026

bedevere-app Bot commented Sep 13, 2026

Copy link
Copy Markdown

GH-157428 is a backport of this pull request to the 3.15 branch.

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Sep 13, 2026
johnslavik pushed a commit to johnslavik/cpython that referenced this pull request Sep 14, 2026
pythongh-63882: Implement empty tests in test_minidom (pythonGH-156677)
b30ff9c 
25 tests were defined as "def testX(self): pass" and reported success
without testing anything.
serhiy-storchaka added a commit that referenced this pull request Sep 14, 2026
[3.13] gh-63882: Implement empty tests in test_minidom (GH-156677) (G…
c698c63 
…H-157427)

25 tests were defined as "def testX(self): pass" and reported success
without testing anything.
(cherry picked from commit f154574)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Sep 14, 2026
[3.14] gh-63882: Implement empty tests in test_minidom (GH-156677) (G…
a4f6216 
…H-157426)

25 tests were defined as "def testX(self): pass" and reported success
without testing anything.
(cherry picked from commit f154574)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
hugovk pushed a commit that referenced this pull request Sep 15, 2026
[3.15] gh-63882: Implement empty tests in test_minidom (GH-156677) (#…
04347ef 
…157428)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL