Repository navigation
[3.14] gh-63882: Implement empty tests in test_minidom (GH-156677) - #157426
Merged
serhiy-storchaka merged 3 commits intoSep 14, 2026
Merged
serhiy-storchaka merged 3 commits into
serhiy-storchaka merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
25 tests were defined as "def testX(self): pass" and reported success without testing anything. (cherry picked from commit f154574) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka
enabled auto-merge (squash)
September 13, 2026 12:55
Copy link
Copy Markdown
Member
|
@serhiy-storchaka test_minidom is failing in this and #157427. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thank you for noticing. One assertion fails because it asserts a bug which was only fixed on main (the fix, #155641, needs exposing a new API in pyexpat, so I was reluctant with backporting it). |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
25 tests were defined as "def testX(self): pass" and reported success
without testing anything.
(cherry picked from commit f154574)
Co-authored-by: Serhiy Storchaka storchaka@gmail.com