Repository navigation
gh-158194: Pin the type lock in PyType_Freeze() - #158674
Open
nascheme wants to merge 1 commit into
Open
nascheme wants to merge 1 commit into
nascheme wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
PyType_Freeze() stopped the world under the type lock without pinning it, so the lock could be released while waiting for the pause. Pin it with type_lock_prevent_release() like the other type-lock callers of types_stop_world().
Copy link
Copy Markdown
Member
Author
|
This fix in this PR is the same code change as suggested by @scasella, without the additional code comment. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Is it possible to add a test that exposes the original issue being fixed? (I can see this might not be consistently reproducible though, not sure what the precedence is for that for) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Yeah, that would be a good idea. I would guess it's possible. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
This probably needs a re-write, given GH-159972. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix PyType_Freeze releasing the type lock while waiting for a stop-the-world pause in the free-threaded build. Another thread could modify the type before the frozen type's caches were invalidated, and the release could deadlock against a thread waiting for the pause with the type lock held.