FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-158194: Pin the type lock in PyType_Freeze() by nascheme · Pull Request #158674 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-158194: Pin the type lock in PyType_Freeze() #158674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nascheme wants to merge 1 commit into
base: main
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 4 Commits 1 Checks 60 Files changed
Open

gh-158194: Pin the type lock in PyType_Freeze() #158674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .c  (1) .rst  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
5 changes: 5 additions & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-10-02-12-30-00.gh-issue-158194.Rk7vWp.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Fix :c:func:`PyType_Freeze` releasing the type lock while waiting for a
stop-the-world pause in the :term:`free-threaded build`. Another thread could
modify the type before the frozen type's caches were invalidated, and the
release could deadlock against a thread waiting for the pause with the type
lock held.
3 changes: 3 additions & 0 deletions Objects/typeobject.c
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -12463,10 +12463,13 @@ PyType_Freeze(PyTypeObject *type)
return -1;
}

pinned_mutexes_t pinned;
BEGIN_TYPE_LOCK();
type_lock_prevent_release(&pinned);
types_stop_world();
type_add_flags(type, Py_TPFLAGS_IMMUTABLETYPE);
types_start_world();
type_lock_allow_release(&pinned);
ASSERT_TYPE_LOCK_HELD();
_PyType_Modified_Unlocked(type);
END_TYPE_LOCK();
Expand Down
Loading
Back | FazBrowse Home | New Git URL