FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-159293: Restore the recursion limit after the free-threading race test by zolaski333 · Pull Request #159311 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-159293: Restore the recursion limit after the free-threading race test #159311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
freakboy3742 merged 1 commit into from
Oct 14, 2026
Conversation 7 Commits 1 Checks 68 Files changed
Merged

gh-159293: Restore the recursion limit after the free-threading race test #159311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .py  (1) .rst  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 2 additions & 0 deletions Lib/test/test_free_threading/test_races.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,8 @@ def mutate():
do_race(set_value, mutate)

def test_racing_recursion_limit(self):
self.addCleanup(sys.setrecursionlimit, sys.getrecursionlimit())

def something_recursive():
def count(n):
if n > 0:
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Tests/2026-10-13-13-34-00.gh-issue-159293.Lr8q2N.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Restore the recursion limit after the free-threading recursion-limit race test

aisk Oct 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Test only changes don't requires a news entry file, please remove it.

terryjreedy Oct 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

'Tests' is one of the blurb options, for test-only PRs, and this was put in the Tests section.

aisk Oct 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The DevGuide has some wording on this: https://github.com/python/devguide/blob/b89ba85ad4d34984812210f6460d619565839971/getting-started/pull-request-lifecycle.rst?plain=1#L218-L219. So does this mean a NEWS entry is just optional for test-only changes?

However, I've seen other test-only PRs where the author was asked to remove the NEWS entry:
to avoid failures in subsequent tests run in the same process.
Loading
Back | FazBrowse Home | New Git URL