Repository navigation
gh-157899: Skip test_readlink_is_marked_as_supports_fd on older macOS & iOS - #159403
Merged
vstinner merged 2 commits intoOct 16, 2026
Merged
vstinner merged 2 commits into
vstinner merged 2 commits into
Conversation
- Generalize @requires_mac_ver logic to add @requires_ios_ver - Skip test_readlink_is_marked_as_supports_fd on lower Apple OS versions
vstinner
approved these changes
Oct 16, 2026
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM. It's a nice thing to use a lazy import for platform in test.support.
@support.requires_mac_ver(13, 0)
@support.requires_ios_ver(16, 0)these checks are consistent with Modules/posixmodule.c code:
# define HAVE_FREADLINK_RUNTIME __builtin_available(macOS 13.0, iOS 16.0, *)_requires_unix_version() could be updated to reuse _requires_apple_os_version() code, but that can be done in a separated PR if needed.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I wanted to write a similar change before I saw your fix. You went further by making _requires_apple_os_version() more generic, nice! |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Follow-up: #159523 "Factorize support._requires_unix_version() code". |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.