FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-157899: Factorize support._requires_unix_version() code by vstinner · Pull Request #159523 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-157899: Factorize support._requires_unix_version() code - #159523

Merged
encukou merged 1 commit into
python:mainfrom
vstinner:requires_unix
Oct 18, 2026
ConversationCommits (1)ChecksFiles changed
Merged

gh-157899: Factorize support._requires_unix_version() code#159523
encukou merged 1 commit into
python:mainfrom
vstinner:requires_unix

Conversation

vstinner commented Oct 16, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Reuse the same code for _requires_unix_version() and _requires_apple_os_version().

Check sys.platform instead of platform.system().

pythongh-157899: Factorize support._requires_unix_version() code
ba16058 
Reuse the same code for _requires_unix_version() and
_requires_apple_os_version().

Check sys.platform instead of platform.system().
bedevere-app Bot added the type-feature A feature request or enhancement label Oct 16, 2026
bedevere-app Bot mentioned this pull request Oct 16, 2026
Closed
vstinner mentioned this pull request Oct 16, 2026
Merged

vstinner commented Oct 16, 2026

Copy link
Copy Markdown
Member Author

cc @encukou

vstinner commented Oct 16, 2026

Copy link
Copy Markdown
Member Author

I checked sys.platform value on the 4 operating systems:

  • macOS: darwin
  • Linux: linux
  • FreeBSD: freebsd
  • iOS: ios

vstinner removed the type-feature A feature request or enhancement label Oct 16, 2026
encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 16, 2026

bedevere-bot commented Oct 16, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit ba16058 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F159523%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 16, 2026

encukou commented Oct 16, 2026

Copy link
Copy Markdown
Member

Looks good!

But also OS-specific, so I'd like to ask Buildbot's opinion.

vstinner commented Oct 16, 2026

Copy link
Copy Markdown
Member Author

So far, 4 buildbot failed, but for reasons unrelated to this change.

buildbot/AMD64 Alpine Linux NoGIL PR

test_lazy_import and test_profiling failed, I created 2 issues:

buildbot/AMD64 Alpine Linux PR

test_lazy_import failed, same issue.

buildbot/AMD64 FreeBSD15 PR
buildbot/AMD64 FreeBSD16 PR

test_lazy_import failed, same issue.

vstinner commented Oct 18, 2026

Copy link
Copy Markdown
Member Author

Buildbot failures are unrelated.

x86-64 MacOS Intel ASAN NoGIL: test_faulthandler failed. See #159606.

PPC64LE CentOS9 Refleaks PR, PPC64LE Fedora Stable Refleaks: test_lazy_import failed.

encukou merged commit 97a7135 into python:main Oct 18, 2026
135 of 149 checks passed

encukou commented Oct 18, 2026

Copy link
Copy Markdown
Member

Thank you!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL