FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-37347: Require SQLite 3.7.3+ by sir-sigurd · Pull Request #17413 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-37347: Require SQLite 3.7.3+ - #17413

Closed
sir-sigurd wants to merge 1 commit into
python:masterfrom
sir-sigurd:sqlite-min-version
ConversationCommits (1)ChecksFiles changed
Closed

bpo-37347: Require SQLite 3.7.3+#17413
sir-sigurd wants to merge 1 commit into
python:masterfrom
sir-sigurd:sqlite-min-version

Conversation

sir-sigurd commented Nov 28, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue37347

#14268 makes sqlite3 module require SQLite 3.7.2+ because it's using sqlite3_create_function_v2(), but actually it was added in SQLite 3.7.3.

This PR:

  • updates setup.py to require SQLite 3.7.3+
  • removes unneeded code that was required for support of older SQLite versions
  • explicitly states required SQLite version in doc of sqlite3 module

ned-deily requested a review from benjaminp November 28, 2019 17:19

ned-deily commented Dec 9, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Thanks for the PR but, as bpo-37347 is closed and was focused on a specific problem, you should open a separate issue to propose dropping support for SQLite versions prior to 3.7.3 and move this PR to it.

berkerpeksag requested changes Dec 11, 2019
View reviewed changes

berkerpeksag left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I agree with Ned that removing pre 3.7.3 code from sqlite3 needs its own issue.

Comment thread Doc/library/sqlite3.rst

.. note::

This module requires SQLite 3.7.3+.

berkerpeksag Dec 11, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think this information can be incorporated into the following paragraph:

The sqlite3 module was written by Gerhard Häring.  It provides a SQL interface
compliant with the DB-API 2.0 specification described by :pep:`249`.

bedevere-bot commented Dec 11, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

csabella commented Jan 25, 2020

Copy link
Copy Markdown
Contributor

@sir-sigurd please address the review comments. If the new bug tracker issue has already been created, please mention it in this PR and close this one. Thanks!

csabella commented May 22, 2020

Copy link
Copy Markdown
Contributor

@sir-sigurd, ping

csabella mentioned this pull request May 23, 2020
Closed
erlend-aasland mentioned this pull request May 30, 2020
Merged
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request May 30, 2020
Require SQLite 3.7.3
a53c9ef 
Remove code required to to support SQLite pre 3.7.3.

Integrate setup.py, docs and unit test changes from PR python#17413

Style changes not related to bpo-40744 were dropped from the merge.
Berker Peksag's suggested documentation changes was included.

See python#17413

Co-written-by: Berker Peksag <berker.peksag@gmail.com>
Co-written-by: Sergey Fedoseev <fedoseev.sergey@gmail.com>
erlend-aasland mentioned this pull request Jun 16, 2020
Merged

sir-sigurd commented Jul 6, 2020

Copy link
Copy Markdown
Contributor Author

Closing in favor of #20909.

sir-sigurd closed this Jul 6, 2020
sir-sigurd deleted the sqlite-min-version branch July 6, 2020 18:31
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Sep 7, 2020
Require SQLite 3.7.3
22fb16b 
Remove code required to to support SQLite pre 3.7.3.

Integrate setup.py, docs and unit test changes from PR python#17413

Style changes not related to bpo-40744 were dropped from the merge.
Berker Peksag's suggested documentation changes was included.

See python#17413

Co-written-by: Berker Peksag <berker.peksag@gmail.com>
Co-written-by: Sergey Fedoseev <fedoseev.sergey@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

berkerpeksag berkerpeksag requested changes
benjaminp Awaiting requested review from benjaminp

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL