FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-83897: Raise on conflicting subparser names. by anntzer · Pull Request #18605 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-83897: Raise on conflicting subparser names. - #18605

Merged
miss-islington merged 1 commit into
python:mainfrom
anntzer:argparse-subparser-conflict
May 1, 2022
ConversationCommits (1)ChecksFiles changed
Merged

gh-83897: Raise on conflicting subparser names.#18605
miss-islington merged 1 commit into
python:mainfrom
anntzer:argparse-subparser-conflict

Conversation

anntzer commented Feb 22, 2020 •
edited by terryjreedy
Loading

Copy link
Copy Markdown
Contributor

Raise an ArgumentError when the same subparser name is added twice to an
ArgumentParser. This is consistent with the (default) behavior when the
same option string is added twice to an ArgumentParser.

(Support for conflict_handler="resolve" could be considered as a
followup feature, although real use cases seem even rarer than
"resolve"ing option-strings.)

Automerge-Triggered-By: GH:rhettinger

bpo-39716: Raise on conflicting subparser names.
57c1ed8 
Raise an ArgumentError when the same subparser name is added twice to an
ArgumentParser.  This is consistent with the (default) behavior when the
same option string is added twice to an ArgumentParser.

(Support for `conflict_handler="resolve"` could be considered as a
followup feature, although real use cases seem even rarer than
"resolve"ing option-strings.)
shihai1991 reviewed Feb 26, 2020
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2020-02-22-12-02-11.bpo-39716.z2WhDQ.rst
@@ -0,0 +1,3 @@
Raise an ArgumentError when the same subparser name is added twice to an

shihai1991 Feb 26, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

How about using added twice or more to replace added twice?

anntzer Feb 26, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You won't be able to add it more than twice if it errors out on the second addition...

shihai1991 Feb 26, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

make sense.

@rhettinger Hi, raymond. Pls review this PR if you have free time.

rhettinger self-requested a review April 30, 2022 22:51

miss-islington commented Apr 30, 2022

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: 3 of 7 required status checks are expected..

rhettinger closed this May 1, 2022
rhettinger reopened this May 1, 2022

miss-islington commented May 1, 2022

Copy link
Copy Markdown
Contributor

@anntzer: Status check is done, and it's a success ✅ .

1 similar comment

miss-islington commented May 1, 2022

Copy link
Copy Markdown
Contributor

@anntzer: Status check is done, and it's a success ✅ .

miss-islington commented May 1, 2022

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: 4 of 7 required status checks are expected..

miss-islington commented May 1, 2022

Copy link
Copy Markdown
Contributor

@anntzer: Status check is done, and it's a success ✅ .

miss-islington commented May 1, 2022

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: 4 of 7 required status checks are expected..

1 similar comment

miss-islington commented May 1, 2022

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: 4 of 7 required status checks are expected..

miss-islington commented May 1, 2022

Copy link
Copy Markdown
Contributor

@anntzer: Status check is done, and it's a success ✅ .

miss-islington merged commit ad5e852 into python:main May 1, 2022
anntzer deleted the argparse-subparser-conflict branch May 1, 2022 11:33
This was referenced May 8, 2022
Merged
Closed
anntzer mannequin mentioned this pull request Apr 10, 2022
Closed
eclipseo mentioned this pull request Jun 26, 2022
Closed
eclipseo pushed a commit to eclipseo/rfpkg that referenced this pull request Jun 26, 2022
Remove register_retire from rfpkg
7095c31 
Don't register again the retire command as it is already done
by pyrpkg. Starting Python 3.11, it creates an error.
See python/cpython#18605

Fix rpmfusion-infra#24
eclipseo mentioned this pull request Jun 26, 2022
Merged
sergiomb2 pushed a commit to rpmfusion-infra/rfpkg that referenced this pull request Jun 27, 2022
Remove register_retire from rfpkg
5f9850f 
Don't register again the retire command as it is already done
by pyrpkg. Starting Python 3.11, it creates an error.
See python/cpython#18605

Fix #24
This was referenced Oct 31, 2022
Closed
Merged
bebound mentioned this pull request Jul 24, 2023
Merged
3 tasks
terryjreedy changed the title bpo-39716: Raise on conflicting subparser names. gh-83897: Raise on conflicting subparser names. Aug 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

shihai1991 shihai1991 left review comments
rhettinger rhettinger approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL