Repository navigation
fix: duplicate subparsers being added to argparse - #2014
Merged
nejch merged 1 commit intoMay 9, 2022
Merged
nejch merged 1 commit into
nejch merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@nejch Seems like Python 3.11.0-beta.1 doesn't like what we are doing... |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I think this is the upstream commit: commit ad5e8520f3e117f45481513014548a39879d30d2
Author: Antony Lee <anntzer.lee@gmail.com>
Date: Sun May 1 08:04:50 2022 +0200
bpo-39716: Raise on conflicting subparser names. (GH-18605)
Raise an ArgumentError when the same subparser name is added twice to an
ArgumentParser. This is consistent with the (default) behavior when the
same option string is added twice to an ArgumentParser.
(Support for `conflict_handler="resolve"` could be considered as a
followup feature, although real use cases seem even rarer than
"resolve"ing option-strings.)
Automerge-Triggered-By: GH:rhettinger
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
The PR upstream: python/cpython#18605 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Probably should create an issue for this instead of my dummy PR 😊 |
Sorry, something went wrong.
JohnVillalovos
force-pushed
the
jlvillal/python3.11beta1
branch
4 times, most recently
from
d64b159 to
14df327
Compare
May 8, 2022 19:20
JohnVillalovos
force-pushed
the
jlvillal/python3.11beta1
branch
from
14df327 to
6f013d1
Compare
May 8, 2022 19:26
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## main #2014 +/- ##
==========================================
- Coverage 92.65% 92.62% -0.04%
==========================================
Files 78 78
Lines 4944 4949 +5
==========================================
+ Hits 4581 4584 +3
- Misses 363 365 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sorry, something went wrong.
nejch
reviewed
May 8, 2022
Comment thread
gitlab/v4/cli.py
Outdated
JohnVillalovos
force-pushed
the
jlvillal/python3.11beta1
branch
2 times, most recently
from
e812380 to
c7dcedd
Compare
May 8, 2022 22:01
nejch
reviewed
May 9, 2022
Python 3.11 added an additional check in the argparse libary which detected duplicate subparsers being added. We had duplicate subparsers being added. Make sure we don't add duplicate subparsers. Closes: #2015
JohnVillalovos
force-pushed
the
jlvillal/python3.11beta1
branch
from
c7dcedd to
f553fd3
Compare
May 9, 2022 13:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.11 added an additional check in the argparse libary which
detected duplicate subparsers being added. We had duplicate subparsers
being added.
Make sure we don't add duplicate subparsers.
Closes: #2015