FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-40112: Fix logic to determine if xlc is ccompiler by aixtools · Pull Request #19225 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-40112: Fix logic to determine if xlc is ccompiler - #19225

Merged
vstinner merged 2 commits into
python:masterfrom
aixtools:bpo-40112-xlc-search-cpp
Apr 3, 2020
ConversationCommits (2)ChecksFiles changed
Merged

bpo-40112: Fix logic to determine if xlc is ccompiler#19225
vstinner merged 2 commits into
python:masterfrom
aixtools:bpo-40112-xlc-search-cpp

Conversation

aixtools commented Mar 30, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue40112

No need for a NEWS entry - I think.

bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Mar 30, 2020
vstinner reviewed Mar 30, 2020
View reviewed changes
Comment thread Lib/distutils/tests/test_config_cmd.py Outdated

aixtools commented Apr 3, 2020

Copy link
Copy Markdown
Contributor Author

Is a NEWS blurb required?

vstinner commented Apr 3, 2020

Copy link
Copy Markdown
Member

Is a NEWS blurb required?

For tests changes, it's fine to not document them.

vstinner merged commit 76db37b into python:master Apr 3, 2020
aixtools deleted the bpo-40112-xlc-search-cpp branch April 3, 2020 15:15

miss-islington commented Apr 7, 2020

Copy link
Copy Markdown
Contributor

Thanks @aixtools for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

bedevere-bot commented Apr 7, 2020

Copy link
Copy Markdown

GH-19408 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 7, 2020
bpo-40112: distutils test_search_cpp: Fix logic to determine if C com…
0401cb1 
…piler is xlc on AIX (pythonGH-19225)

(cherry picked from commit 76db37b)

Co-authored-by: Michael Felt <aixtools@users.noreply.github.com>

miss-islington commented Apr 8, 2020

Copy link
Copy Markdown
Contributor

Thanks @aixtools for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington commented Apr 8, 2020

Copy link
Copy Markdown
Contributor

Sorry @aixtools and @vstinner, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 76db37b1d37a9daadd9e5b320f2d5a53cd1352ec 3.8

bedevere-bot commented Apr 8, 2020

Copy link
Copy Markdown

GH-19444 is a backport of this pull request to the 3.8 branch.

vstinner added a commit that referenced this pull request Apr 9, 2020
bpo-40112: distutils test_search_cpp: Fix logic to determine if C com…
cd8e1da 
…piler is xlc on AIX (GH-19225) (GH-19444)

(cherry picked from commit 76db37b)

Co-authored-by: Michael Felt <aixtools@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner left review comments

Assignees

vstinner

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL