| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
@zooba Thanks for your patience, let me know if you need anything else to move forward with the integration 🙏 |
Sorry, something went wrong.
@jcfr Seems like a release note could be added in the meantime. |
Sorry, something went wrong.
|
Ping? Any update here? It'd be nice to have this in 3.9. |
Sorry, something went wrong.
|
Seems this will miss 3.10 as well. |
Sorry, something went wrong.
|
Ping. This would be really really nice to have sometime soon 👍 |
Sorry, something went wrong.
|
I thought we'd already added this? I guess if it's not there, then we should. Definitely needs a NEWS entry, probably deserves a What's New as well. Not sure if there's any place in the documentation that would suit, but if so, we should mention it for sure. |
Sorry, something went wrong.
I can definitely add an entry, What about the C-API section ? See https://github.com/python/cpython/tree/main/Misc/NEWS.d/next/C%20API |
Sorry, something went wrong.
|
I added draft documentation and the NEWS entry for the macro. However, they need improvements. |
Sorry, something went wrong.
|
@arhadthedev Thanks for your help moving this forward 🙏 |
Sorry, something went wrong.
|
I haven't tested the commands added to the docs, but if they do work as described and produce the files, then this looks fine to me. |
Sorry, something went wrong.
|
It seems that if building Python by oneself, python's lib file will not be found in virtual environment. Hope this issue fixes as quickly as possible |
Sorry, something went wrong.
|
No, virtual environment is only for Python libraries. You'll need to look in base_prefix to find native import libraries. |
Sorry, something went wrong.
|
@zooba My question is like this:rosinality/stylegan2-pytorch#325 (comment) So, is it more like to be a question about venv? |
Sorry, something went wrong.
|
It looks like Torch is deciding those settings, and it's deciding wrong about where to find the libs files. There's a revamp of sysconfig going on that will eventually provide a better option for them to find it, but for now, either they need to use sys.base_prefix instead of sys.prefix, or if they already are (which they might be), then there's something wrong with your venv (maybe you've chained multiple venvs together in some unsupported way?) |
Sorry, something went wrong.
|
@zooba I can give some additional informations. For exmaple, And that's maybe why dll file cannot be found? |
Sorry, something went wrong.
|
Yeah, many tools are not going to work well when running from a CPython build directory. It's an unsupported configuration. Try using the PC/layout tool (e.g. python PC\layout --copy <directory> --preset-default) to create an installed-shape directory. That will have the libs at the usual place relative to python.exe. (You need to re-run the command if you rebuild Python, but it does incremental copying. Also, don't run the copied Python from the CPython source directory or it'll get the wrong Lib dir.) |
Sorry, something went wrong.
|
Any progress here? I see conflicts, so at least a rebase is in order. It'd be nice to get this into 3.13 at least… @vstinner Interested in shepherding this C API change at all? |
Sorry, something went wrong.
|
A rebase ought to be enough, and when someone confirms that the build commands shown in the new documentation are correct then this can be merged (as per my last message). |
Sorry, something went wrong.
|
This would potentially be extremly helpful, any chance that this will get merged at some point? |
Sorry, something went wrong.
|
It looks like the rebase isn't coming, so someone will need to submit a new PR. It also looks like my last hesitation was that the commands in the docs weren't tested. |
Sorry, something went wrong.
…linking Define PY_NO_LINK_LIB to build extension disabling pragma based auto-linking. This is relevant when using build-system generator (e.g CMake) where the linking is explicitly handled
There was a problem hiding this comment.
Nothing wrong with the PR as it is, but I think we can do a bit of tidying here if you want.
Sorry, something went wrong.
| #ifdef MS_COREDLL | ||
| # if !defined(Py_BUILD_CORE) && !defined(Py_BUILD_CORE_BUILTIN) | ||
| /* not building the core - must be an ext */ | ||
| # if defined(_MSC_VER) | ||
| # if defined(_MSC_VER) && !defined(Py_NO_LINK_LIB) |
There was a problem hiding this comment.
This whole set of conditions is pretty ugly... any interest in simplifying?
Ideally in this order:
The order doesn't need to be spelled out to anyone reading it, but it should make it easiest to read (the first check has the best name) and easiest to maintain (alternate compilers can be supported in the "middle", not the edges).
It also really doesn't need to be indented by 8 characters. Four would be plenty.
Sorry, something went wrong.
| /* Define Py_NO_LINK_LIB to build extension disabling pragma | ||
| based auto-linking. | ||
| This is relevant when using build-system generator (e.g CMake) where | ||
| the linking is explicitly handled */ |
There was a problem hiding this comment.
This comment isn't important for this file, though a short header above the entire block (something like "automatically reference python3x.lib") might make it easier to understand the purpose without reading the whole way through.
Sorry, something went wrong.
|
Guess we're not getting those improvements, so we'll leave them for later. Should be an easy first contribution for a sprint. |
Sorry, something went wrong.
|
Thanks everyone for the help moving this forward 🙏 |
Sorry, something went wrong.
| :file:`Python.h` triggers an implicit, configure-aware link with the | ||
| library. The header file chooses :file:`pythonXY_d.lib` for Debug, | ||
| :file:`pythonXY.lib` for Release, and :file:`pythonX.lib` for Release with | ||
| the `Limited API <stable-application-binary-interface>`_ enabled. |
There was a problem hiding this comment.
See also #134830
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Define PY_NO_LINK_LIB to build extension disabling pragma based
auto-linking. This is relevant when using build-system generator
(e.g CMake) where the linking is explicitly handled
https://bugs.python.org/issue38728