Repository navigation
bpo-29587: Remove the exc_value NULL check in _gen_throw() - #19877
Merged
cjerdonek merged 2 commits intoMay 3, 2020
Merged
cjerdonek merged 2 commits into
cjerdonek merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
gvanrossum
approved these changes
May 3, 2020
gvanrossum
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Good luck!
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Thanks! :) I'll be posting a comment on the issue with what I found.. |
Sorry, something went wrong.
This was referenced May 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another follow-up to PR #19823, removing the check that exc_value isn't NULL prior to calling _PyErr_ChainExceptions(). This makes it so that exception chaining can occur in more cases.
https://bugs.python.org/issue29587