bpo-41858: Fix incomplete line on optparse documentation - #22407
Merged
terryjreedy merged 2 commits intoSep 27, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This line seems to be incomplete. This fix come from the translation to spanish of @fjsevilla-dev on python/python-docs-es#758. reading the proposal for the translate has sense add `the next lines`.
taleinat
reviewed
Sep 26, 2020
taleinat
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
In my eyes (I'm a native English speaker but not a language expert), "the following lines" is not required, though I agree that this sentence is slightly too terse without it.
I'd change this to "users can run either one of:".
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
On second thought, I prefer @terryjreedy's suggestion on the b.p.o. issue. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @eamanu for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 27, 2020
The existing line is easily read as being incomplete. (cherry picked from commit 00eb063) Co-authored-by: Emmanuel Arias <eamanu@yaerobi.com>
Copy link
Copy Markdown
|
GH-22425 is a backport of this pull request to the 3.9 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 27, 2020
The existing line is easily read as being incomplete. (cherry picked from commit 00eb063) Co-authored-by: Emmanuel Arias <eamanu@yaerobi.com>
Copy link
Copy Markdown
|
GH-22426 is a backport of this pull request to the 3.8 branch. |
Sorry, something went wrong.
miss-islington
added a commit
that referenced
this pull request
Sep 27, 2020
miss-islington
added a commit
that referenced
this pull request
Sep 27, 2020
shihai1991
added a commit
to shihai1991/cpython
that referenced
this pull request
Sep 29, 2020
* origin/master: (113 commits) bpo-41773: Raise exception for non-finite weights in random.choices(). (pythonGH-22441) bpo-41873: Add vectorcall for float() (pythonGH-22432) bpo-41861: Convert _sqlite3 PrepareProtocolType to heap type (pythonGH-22428) bpo-41842: Add codecs.unregister() function (pythonGH-22360) bpo-41875: Use __builtin_unreachable when possible (pythonGH-22433) bpo-40105: ZipFile truncate in append mode with shorter comment (pythonGH-19337) bpo-41870: Use PEP 590 vectorcall to speed up bool() (pythonGH-22427) [doc] Leverage the fact that the actual types can now be indexed for typing (pythonGH-22340) bpo-41861: Convert _sqlite3 cache and node static types to heap types (pythonGH-22417) bpo-41858: Clarify line in optparse doc (pythonGH-22407) Revert "Fix all Python Cookbook links (python#22205)" (pythonGH-22424) bpo-1635741: Port _bisect module to multi-phase init (pythonGH-22415) bpo-41428: Fix compiler warning in unionobject.c (pythonGH-22416) Fix logging error message (pythonGH-22410) bpo-39934: Account for control blocks in 'except' in compiler. (pythonGH-22395) bpo-41775: Make 'IDLE Shell' the shell title (python#22399) bpo-41428: Fix compiler warnings in unionobject.c (pythonGH-22388) bpo-41654: Fix compiler warning in MemoryError_dealloc() (pythonGH-22387) bpo-41833: threading.Thread now uses the target name (pythonGH-22357) bpo-30155: Add macros to get tzinfo from datetime instances (pythonGH-21633) ...
ambv
pushed a commit
to ambv/cpython
that referenced
this pull request
Oct 4, 2020
The existing line is easily read as being incomplete. (cherry picked from commit 00eb063) Co-authored-by: Emmanuel Arias <eamanu@yaerobi.com>
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
The existing line is easily read as being incomplete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This line seems to be incomplete. This fix come from the translation
to spanish of @fjsevilla-dev on python/python-docs-es#758.
reading the proposal for the translate has sense add the next lines.
I thinks that NEWS could be ignore here.
https://bugs.python.org/issue41858