bpo-41861: Convert sqlite3 cache and node types to heap types - #22417
Merged
vstinner merged 8 commits intoSep 27, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
vstinner
reviewed
Sep 26, 2020
Comment thread
Modules/_sqlite/cache.c
Outdated
Comment thread
Modules/_sqlite/cache.c
Outdated
Comment thread
Misc/NEWS.d/next/Library/2020-09-26-12-16-28.bpo-41861.3xTsIp.rst
Outdated
This reverts commit a3e33bd.
Copy link
Copy Markdown
Contributor
Author
|
Thanks for your comments, @vstinner. Please take another look. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@vstinner I've prepared the other PR's, and after applying the same suggestions to every (upcoming) PR, I've gotten rid of the reference leaks. So now, all the sqlite3 types are ready. I suggest to squash the statement and prepare protocol type in one PR, and then keep the rest as separate PRs. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Merged, thanks! You can now convert the next static types ;-) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Yay, will do :) Thanks for reviewing! |
Sorry, something went wrong.
shihai1991
added a commit
to shihai1991/cpython
that referenced
this pull request
Sep 29, 2020
* origin/master: (113 commits) bpo-41773: Raise exception for non-finite weights in random.choices(). (pythonGH-22441) bpo-41873: Add vectorcall for float() (pythonGH-22432) bpo-41861: Convert _sqlite3 PrepareProtocolType to heap type (pythonGH-22428) bpo-41842: Add codecs.unregister() function (pythonGH-22360) bpo-41875: Use __builtin_unreachable when possible (pythonGH-22433) bpo-40105: ZipFile truncate in append mode with shorter comment (pythonGH-19337) bpo-41870: Use PEP 590 vectorcall to speed up bool() (pythonGH-22427) [doc] Leverage the fact that the actual types can now be indexed for typing (pythonGH-22340) bpo-41861: Convert _sqlite3 cache and node static types to heap types (pythonGH-22417) bpo-41858: Clarify line in optparse doc (pythonGH-22407) Revert "Fix all Python Cookbook links (python#22205)" (pythonGH-22424) bpo-1635741: Port _bisect module to multi-phase init (pythonGH-22415) bpo-41428: Fix compiler warning in unionobject.c (pythonGH-22416) Fix logging error message (pythonGH-22410) bpo-39934: Account for control blocks in 'except' in compiler. (pythonGH-22395) bpo-41775: Make 'IDLE Shell' the shell title (python#22399) bpo-41428: Fix compiler warnings in unionobject.c (pythonGH-22388) bpo-41654: Fix compiler warning in MemoryError_dealloc() (pythonGH-22387) bpo-41833: threading.Thread now uses the target name (pythonGH-22357) bpo-30155: Add macros to get tzinfo from datetime instances (pythonGH-21633) ...
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@vstinner, ref. PR #22409
https://bugs.python.org/issue41861