bpo-41861: Convert sqlite3 to PEP 384 - #22409
Conversation
Sorry, something went wrong.
FIXME: leaks refs
FIXME: Leaks refs
vstinner
left a comment
There was a problem hiding this comment.
Sorry, but this PR is too large to be easily reviewed.
It seems like the PR converts static types to heap types. Can you try to write a first PR which only modify a few files and convert few types (ex: 3), which would be easier to review?
Please don't propose multiple PRs in parallel, since conflicts in PyInit__sqlite3() are likely.
For example, starting by only converting cache types:
extern PyTypeObject pysqlite_NodeType; extern PyTypeObject pysqlite_CacheType;
Sorry, something went wrong.
Of course. I'll remove the two problematic commits and create a new PR. Thanks!
Acknowledged. |
Sorry, something went wrong.
TODO:
@berkerpeksag or @vstinner, could you point me in the right direction regarding solving the ref. leaks? I've been testing using python.exe -m test -F -r -j1 -R 3:10 test_sqlite.
https://www.python.org/dev/peps/pep-0384/
First step of converting sqlite3 to multi-phase init. AFAICS, the next step would be dynamic state.
https://bugs.python.org/issue41861