Repository navigation
bpo-41991: Remove _PyObject_HasAttrId - #22629
Merged
serhiy-storchaka merged 1 commit intoOct 10, 2020
Merged
serhiy-storchaka merged 1 commit into
serhiy-storchaka merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
serhiy-storchaka
requested review from
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
October 10, 2020 07:49
It can silence arbitrary exceptions.
serhiy-storchaka
force-pushed
the
capi-remove-_PyObject_HasAttrId
branch
from
6562ceb to
9307e7d
Compare
October 10, 2020 07:58
pablogsal
approved these changes
Oct 10, 2020
pablogsal
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Thanks, Serhiy for cleaning up this !
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.9 due to a conflict. |
Sorry, something went wrong.
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
It can silence arbitrary exceptions.
19 of 21 tasks
freundTech
added a commit
to freundTech/mypy
that referenced
this pull request
Mar 11, 2021
_PyObject_HasAttrId() has been removed in python/cpython#22629
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
It can silence arbitrary exceptions.
freundTech
added a commit
to freundTech/mypy
that referenced
this pull request
Mar 15, 2021
_PyObject_HasAttrId() has been removed in python/cpython#22629
JukkaL
pushed a commit
to python/mypy
that referenced
this pull request
Mar 16, 2021
* Fix mypyc failing to compile on CPython 3.10.0a6 _PyObject_HasAttrId() has been removed in python/cpython#22629 * Keep using _PyObject_HasAttrId when python version is too old We could potentionally already use _PyObject_LookupAttrId starting with python 3.7 instead of 3.10. I'm not sure if we should switch as soon or as late as possible. Alternatively we could also try backporting _PyObject_LookupAttrId to <3.7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can silence arbitrary exceptions.
https://bugs.python.org/issue41991