Fix mypyc failing to compile on CPython 3.10.0a6 (#10202) - #57
Merged
sthagen merged 1 commit intoMar 17, 2021
Merged
sthagen merged 1 commit into
sthagen merged 1 commit into
Conversation
Copy link
Copy Markdown
Owner
Sorry, something went wrong.
* Fix mypyc failing to compile on CPython 3.10.0a6 _PyObject_HasAttrId() has been removed in python/cpython#22629 * Keep using _PyObject_HasAttrId when python version is too old We could potentionally already use _PyObject_LookupAttrId starting with python 3.7 instead of 3.10. I'm not sure if we should switch as soon or as late as possible. Alternatively we could also try backporting _PyObject_LookupAttrId to <3.7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_PyObject_HasAttrId() has been removed in
python/cpython#22629
We could potentionally already use _PyObject_LookupAttrId starting with
python 3.7 instead of 3.10. I'm not sure if we should switch as soon or
as late as possible.
Alternatively we could also try backporting _PyObject_LookupAttrId to
<3.7.
Have you read the Contributing Guidelines?
(Once you have, delete this section. If you leave it in, your PR may be closed without action.)
Description
(Explain how this PR changes mypy.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)