FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-41282: (PEP 632) Deprecate distutils.sysconfig (partial implementation of the PEP) by frenzymadness · Pull Request #23142 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-41282: (PEP 632) Deprecate distutils.sysconfig (partial implementation of the PEP) - #23142

Merged
encukou merged 24 commits into
python:masterfrom
frenzymadness:distutils_sysconfig
Apr 23, 2021
ConversationCommits (24)ChecksFiles changed
Merged

bpo-41282: (PEP 632) Deprecate distutils.sysconfig (partial implementation of the PEP)#23142
encukou merged 24 commits into
python:masterfrom
frenzymadness:distutils_sysconfig

Conversation

frenzymadness commented Nov 4, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

This change:

  • merges distutils.sysconfig into sysconfig while keeping the original functionality and
  • marks distutils.sysconfig as deprecated

Commits basically describe my progress step by step. Some discussions already happened in my private PR.

PEP 632 is still a draft so I'm opening this PR the same. PEP proposal and discussion.

https://bugs.python.org/issue41282

frenzymadness mentioned this pull request Nov 4, 2020
Closed
frenzymadness marked this pull request as draft November 4, 2020 11:31
merwok reviewed Nov 4, 2020
View reviewed changes
Comment thread Lib/sysconfig.py Outdated
merwok reviewed Nov 4, 2020
View reviewed changes
Comment thread Lib/sysconfig.py Outdated
zooba self-assigned this Nov 4, 2020

github-actions Bot commented Dec 16, 2020

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
merwok removed the stale Stale PR or inactive for long period of time. label Dec 16, 2020

frenzymadness commented Dec 16, 2020

Copy link
Copy Markdown
Contributor Author

This PR is waiting for a final decision about the PEP.

github-actions Bot commented Jan 16, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Jan 16, 2021
merwok removed awaiting review stale Stale PR or inactive for long period of time. labels Jan 16, 2021

pradyunsg commented Jan 23, 2021

Copy link
Copy Markdown
Member

The PEP is accepted now.

merwok reviewed Jan 23, 2021
View reviewed changes
Comment thread Doc/distutils/apiref.rst Outdated
frenzymadness changed the title PEP 632: Deprecate distutils.sysconfig (partial implementation of the PEP) bpo-41282: (PEP 632) Deprecate distutils.sysconfig (partial implementation of the PEP) Feb 9, 2021

frenzymadness commented Feb 9, 2021

Copy link
Copy Markdown
Contributor Author

The pep is accepted so this PR is no longer a draft. Also, a note about the deprecation already exists here so I think it's enough to mention it once.

frenzymadness marked this pull request as ready for review February 9, 2021 12:38

encukou commented Feb 12, 2021

Copy link
Copy Markdown
Member

Can you add a NEWS entry?
(The blurb tool is packaged in Fedora, FWIW.)

frenzymadness commented Feb 15, 2021

Copy link
Copy Markdown
Contributor Author

News entry added.

zooba commented Feb 15, 2021

Copy link
Copy Markdown
Member

I have no other comments, so unless someone else spots something I'll get this merged before the next alpha release. Thanks, @frenzymadness!

frenzymadness commented Feb 28, 2021

Copy link
Copy Markdown
Contributor Author

I have no other comments, so unless someone else spots something I'll get this merged before the next alpha release. Thanks, @frenzymadness!

Thank you! AFAIK the next alpha should be released tomorrow. Will we include this in it?

frenzymadness commented Apr 16, 2021

Copy link
Copy Markdown
Contributor Author

I've rebased the commits and fixed a conflict. The failing test is not related to this change.

Could you please merge this?

frenzymadness commented Apr 16, 2021

Copy link
Copy Markdown
Contributor Author

@encukou see the last commit and PTAL.

pradyunsg commented Apr 16, 2021

Copy link
Copy Markdown
Member

And... Could someone also relabel this, to remove the "DO-NOT-MERGE" label here? :)

merwok reviewed Apr 16, 2021
View reviewed changes
Comment thread Doc/distutils/apiref.rst Outdated
Update Doc/distutils/apiref.rst
cd8e387 
Co-authored-by: Éric Araujo <merwok@netwok.org>

frenzymadness commented Apr 22, 2021

Copy link
Copy Markdown
Contributor Author

@zooba could you please take a look at this PR? The time of the first beta release is approaching.

encukou commented Apr 23, 2021

Copy link
Copy Markdown
Member

The patch looks good to me, it was seen by many people and I see no objections. I'll merge and watch the buildbots.

encukou merged commit 90d02e5 into python:master Apr 23, 2021
frenzymadness deleted the distutils_sysconfig branch April 26, 2021 08:00

hroncok commented Jun 8, 2021

Copy link
Copy Markdown
Contributor

I think there is a regression in distutils.sysconfig.parse_makefile() caused by this change.

https://bugs.python.org/issue44351

frenzymadness mentioned this pull request Jun 10, 2021
Merged
This was referenced Dec 21, 2021
Closed
Closed
jaraco mentioned this pull request May 9, 2022
Closed
jkloth mentioned this pull request May 18, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

merwok merwok left review comments
pradyunsg pradyunsg left review comments
lysnikolaou Awaiting requested review from lysnikolaou
pablogsal Awaiting requested review from pablogsal

Assignees

zooba

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL