Repository navigation
bpo-44351: Restore back parse_makefile in distutils.sysconfig - #26637
Merged
encukou merged 1 commit intoJun 11, 2021
Merged
encukou merged 1 commit into
encukou merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The function uses distutils.text_file.TextFile and therefore behaves differently than _parse_makefile in sysconfig.
hroncok
approved these changes
Jun 11, 2021
hroncok
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
The code is different than Python 3.9 code wrt. compiled re patterns / strings. The differences are reasonable. Other than that, it is a straight revert / restore.
I'd add a regression test, however this is distutils, so not a hard requirement.
Thank you.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @frenzymadness for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-26673 is a backport of this pull request to the 3.10 branch. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function uses distutils.text_file.TextFile and therefore
behaves differently than _parse_makefile in sysconfig.
This is a regression caused by a try to merge distutils.sysconfig and sysconfig in #23142
https://bugs.python.org/issue44351