FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-42384: pdb: correctly populate sys.path[0] by hexagonrecursion · Pull Request #23338 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-42384: pdb: correctly populate sys.path[0] - #23338

Merged
miss-islington merged 3 commits into
python:masterfrom
hexagonrecursion:fix-issue42383-and-issue42384
Jan 22, 2021
ConversationCommits (3)ChecksFiles changed
Merged

bpo-42384: pdb: correctly populate sys.path[0]#23338
miss-islington merged 3 commits into
python:masterfrom
hexagonrecursion:fix-issue42383-and-issue42384

Conversation

hexagonrecursion commented Nov 17, 2020 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue42384

Automerge-Triggered-By: GH:gvanrossum

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

shihai1991 commented Nov 17, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

The new tests I added fail on Windows. I'll fix them later.

Thanks for your contribute, Looks like you need sign the CLA :)

shihai1991 reviewed Nov 17, 2020
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2020-11-17-14-30-12.bpo-42383.ubl0Y_.rst Outdated
@@ -0,0 +1,2 @@
Fix pdb: previously pdb would fail to restart the debugging target if it was

shihai1991 Nov 17, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

a PR own a misc file is enough. in here

hexagonrecursion Nov 17, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

a PR own a misc file is enough. in here

I do not understand. Are you saying I should merge the two misc files into one?

shihai1991 Nov 18, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

yes, you are right.

shihai1991 Nov 18, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

IMHO, one PR always means a bugfix or a sepeareted developing feature, so a single misc file is good enough.

hexagonrecursion Nov 18, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Here is the situation: I initially treated pdb as a black box. It had two separate bugs. One bug affected how sys.path[0] was populated while the other prevented pdb from properly restarting the target. So I opened two bugs. Then I looked at the code and it just so happens that changing one line fixes both bugs. I'm not sure what to do now.

shihai1991 Nov 18, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

My personal experience(NOT the official way):

  • Creating the first PR to solve the fist issue you want fixed.
  • After the first PR merged, we can add some description info in second issue, something like: After PR-XXX merged, this issue should be resolved by the way.. MAYBE you can create an another PR to add the testcase of the second issue.

This comment has been minimized.

Sign in to view
hexagonrecursion changed the title bpo-42383 and bpo-42384: pdb: reexecute the right file even if the current directory changes and correctly populate sys.path[0] bpo-42384: pdb: correctly populate sys.path[0] Nov 19, 2020

hexagonrecursion commented Nov 19, 2020

Copy link
Copy Markdown
Contributor Author

Following this instructions

#23338 (comment)

My personal experience(NOT the official way):

* Creating the first PR to solve the fist issue you want fixed.

* After the first PR merged, we can add some description info in second issue, something like: `After PR-XXX merged, this issue should be resolved by the way.`. MAYBE you can create an another PR to add the testcase of the second issue.

I have updated the pull request.

hexagonrecursion mentioned this pull request Nov 19, 2020
Merged

github-actions Bot commented Dec 20, 2020

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 20, 2020

gvanrossum commented Dec 22, 2020

Copy link
Copy Markdown
Member

This looks like the original behavior is just a bug (I think maybe far in the past the path value was always relative) and I am okay with backporting to 3.8 and 3.9.

github-actions Bot removed the stale Stale PR or inactive for long period of time. label Dec 23, 2020

github-actions Bot commented Jan 22, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Jan 22, 2021
gvanrossum added needs backport to 3.8 and removed stale Stale PR or inactive for long period of time. labels Jan 22, 2021
miss-islington merged commit 8603dfb into python:master Jan 22, 2021

miss-islington commented Jan 22, 2021

Copy link
Copy Markdown
Contributor

Thanks @hexagonrecursion for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

bedevere-bot commented Jan 22, 2021

Copy link
Copy Markdown

GH-24290 is a backport of this pull request to the 3.9 branch.

bedevere-bot commented Jan 22, 2021

Copy link
Copy Markdown

GH-24291 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 22, 2021
bpo-42384: pdb: correctly populate sys.path[0] (pythonGH-23338)
1392e78 
Automerge-Triggered-By: GH:gvanrossum
(cherry picked from commit 8603dfb)

Co-authored-by: Andrey Bienkowski <hexagonrecursion@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 22, 2021
bpo-42384: pdb: correctly populate sys.path[0] (pythonGH-23338)
72ed9fe 
Automerge-Triggered-By: GH:gvanrossum
(cherry picked from commit 8603dfb)

Co-authored-by: Andrey Bienkowski <hexagonrecursion@gmail.com>

shihai1991 commented Jan 22, 2021

Copy link
Copy Markdown
Member

Thanks Andrey for your contirbute.
Thanks Guido for your review.

hexagonrecursion deleted the fix-issue42383-and-issue42384 branch January 24, 2021 16:38
This was referenced Jan 25, 2021
Merged
Merged
gvanrossum pushed a commit that referenced this pull request Jan 25, 2021
[3.9] bpo-42384: pdb: correctly populate sys.path[0] (GH-23338) (#24321)
f2df795
gvanrossum pushed a commit that referenced this pull request Jan 25, 2021
[3.8] bpo-42384: pdb: correctly populate sys.path[0] (GH-23338) (#24320)
c10180e
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
bpo-42384: pdb: correctly populate sys.path[0] (pythonGH-23338)
d5b73b2 
Automerge-Triggered-By: GH:gvanrossum
johnslavik mentioned this pull request Dec 5, 2025
Closed
jaraco mentioned this pull request Dec 8, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

shihai1991 shihai1991 left review comments
gvanrossum gvanrossum approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL