FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-42383: pdb: do not fail to restart the target if the current directory changed by hexagonrecursion · Pull Request #23412 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-42383: pdb: do not fail to restart the target if the current directory changed - #23412

Merged
gvanrossum merged 1 commit into
python:masterfrom
hexagonrecursion:tests-for-bpo-42383
Jan 25, 2021
ConversationCommits (1)ChecksFiles changed
Merged

bpo-42383: pdb: do not fail to restart the target if the current directory changed#23412
gvanrossum merged 1 commit into
python:masterfrom
hexagonrecursion:tests-for-bpo-42383

Conversation

hexagonrecursion commented Nov 19, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

#23338 should be merged first because it contains the actual fix since both https://bugs.python.org/issue42383 and https://bugs.python.org/issue42384 can be fixed by adding one line.

Following this instructions

#23338 (comment)

My personal experience(NOT the official way):

* Creating the first PR to solve the fist issue you want fixed.

* After the first PR merged, we can add some description info in second issue, something like: `After PR-XXX merged, this issue should be resolved by the way.`. MAYBE you can create an another PR to add the testcase of the second issue.

I opened a separate PR for bpo-42383

https://bugs.python.org/issue42383

github-actions Bot commented Dec 20, 2020

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 20, 2020
bpo-42383: pdb: do not fail to restart the target if the current dire…
4a28e5b 
…ctory changed

This commit only adds tests and a news entry. The actual bug was fixed in the earlier commit.

hexagonrecursion commented Jan 25, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor Author

Now that #23338 is merged this can also be merged. #23338 fixed both bpo-42383 and bpo-42384 with a one-line change, but the test for bpo-42383 was split into a separate PR as recommended in #23338 (comment)

This was referenced Jan 25, 2021
Merged
Merged

gvanrossum commented Jan 25, 2021

Copy link
Copy Markdown
Member

Something's missing -- this just adds a test but doen't change anything in pdb.py.

gvanrossum approved these changes Jan 25, 2021
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oh wait that's because the other PR fixed both issues.

Next time I think you should just do everything in one PR. :-)

gvanrossum removed the stale Stale PR or inactive for long period of time. label Jan 25, 2021
gvanrossum merged commit 501d4a5 into python:master Jan 25, 2021

bedevere-bot commented Jan 25, 2021

Copy link
Copy Markdown

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

gvanrossum commented Jan 25, 2021

Copy link
Copy Markdown
Member

@hexagonrecursion Is it worth backporting this too?

hexagonrecursion deleted the tests-for-bpo-42383 branch January 26, 2021 10:15

hexagonrecursion commented Jan 26, 2021

Copy link
Copy Markdown
Contributor Author

@hexagonrecursion Is it worth backporting this too?

I already did.

gvanrossum pushed a commit that referenced this pull request Jan 26, 2021
[3.9] bpo-42383: pdb: do not fail to restart the target if the curren…
f8cfe54 
…t directory changed (GH-23412) (#24322)
gvanrossum pushed a commit that referenced this pull request Jan 26, 2021
[3.8] bpo-42383: pdb: do not fail to restart the target if the curre…
d863dee 
…nt directory changed (GH-23412) (#24323)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
bpo-42383: pdb: do not fail to restart the target if the current dire…
fe65394 
…ctory changed (python#23412)

This commit only adds tests and a news entry. The actual bug was fixed in the earlier commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gvanrossum gvanrossum approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL