Repository navigation
bpo-42195: Override _CallableGenericAlias's __getitem__ - #23915
Merged
miss-islington merged 1 commit intoDec 24, 2020
Merged
miss-islington merged 1 commit into
miss-islington merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I think we can skip news, it can share the same news item as the original PR. |
Sorry, something went wrong.
16 tasks done
gvanrossum
approved these changes
Dec 24, 2020
Copy link
Copy Markdown
Contributor
|
Thanks @Fidget-Spinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 24, 2020
Added `__getitem__` for `_CallableGenericAlias` so that it returns a subclass (itself) of `types.GenericAlias` rather than the default behavior of returning a plain `types.GenericAlias`. This fixes `repr` issues occuring after `TypeVar` substitution arising from the previous behavior. (cherry picked from commit 6dd3da3) Co-authored-by: kj <28750310+Fidget-Spinner@users.noreply.github.com>
Copy link
Copy Markdown
|
GH-23916 is a backport of this pull request to the 3.9 branch. |
Sorry, something went wrong.
miss-islington
added a commit
that referenced
this pull request
Dec 24, 2020
Added `__getitem__` for `_CallableGenericAlias` so that it returns a subclass (itself) of `types.GenericAlias` rather than the default behavior of returning a plain `types.GenericAlias`. This fixes `repr` issues occuring after `TypeVar` substitution arising from the previous behavior. (cherry picked from commit 6dd3da3) Co-authored-by: kj <28750310+Fidget-Spinner@users.noreply.github.com>
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
Added `__getitem__` for `_CallableGenericAlias` so that it returns a subclass (itself) of `types.GenericAlias` rather than the default behavior of returning a plain `types.GenericAlias`. This fixes `repr` issues occuring after `TypeVar` substitution arising from the previous behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added __getitem__ for _CallableGenericAlias so that it returns a subclass (itself) of types.GenericAlias rather than the default behavior of returning a plain types.GenericAlias. This fixes repr issues occuring after TypeVar substitution arising from the previous behavior.
https://bugs.python.org/issue42195
Automerge-Triggered-By: GH:gvanrossum