Repository navigation
[3.9] bpo-42195: Override _CallableGenericAlias's __getitem__ (GH-23915) - #23916
Merged
miss-islington merged 1 commit intoDec 24, 2020
Merged
miss-islington merged 1 commit into
miss-islington merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Added `__getitem__` for `_CallableGenericAlias` so that it returns a subclass (itself) of `types.GenericAlias` rather than the default behavior of returning a plain `types.GenericAlias`. This fixes `repr` issues occuring after `TypeVar` substitution arising from the previous behavior. (cherry picked from commit 6dd3da3) Co-authored-by: kj <28750310+Fidget-Spinner@users.noreply.github.com>
Copy link
Copy Markdown
Contributor
Author
|
@Fidget-Spinner: Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
gvanrossum
approved these changes
Dec 24, 2020
Copy link
Copy Markdown
Contributor
Author
|
@Fidget-Spinner: Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@Fidget-Spinner: Status check is done, and it's a failure ❌ . |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added __getitem__ for _CallableGenericAlias so that it returns a subclass (itself) of types.GenericAlias rather than the default behavior of returning a plain types.GenericAlias. This fixes repr issues occuring after TypeVar substitution arising from the previous behavior.
(cherry picked from commit 6dd3da3)
Co-authored-by: kj 28750310+Fidget-Spinner@users.noreply.github.com
https://bugs.python.org/issue42195