FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-24464: Deprecate sqlite3.enable_shared_cache by erlend-aasland · Pull Request #24008 · python/cpython · GitHub

/ cpython Public

bpo-24464: Deprecate sqlite3.enable_shared_cache - #24008

Merged
berkerpeksag merged 10 commits into
python:masterfrom
erlend-aasland:sqlite-shared-cache
Jan 6, 2021
ConversationCommits (10)ChecksFiles changed
Merged

bpo-24464: Deprecate sqlite3.enable_shared_cache#24008
berkerpeksag merged 10 commits into
python:masterfrom
erlend-aasland:sqlite-shared-cache

Conversation

erlend-aasland commented Dec 30, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

erlend-aasland commented Dec 30, 2020

Copy link
Copy Markdown
Contributor Author

cc @ned-deily, @ronaldoussoren

erlend-aasland commented Dec 30, 2020

Copy link
Copy Markdown
Contributor Author

FYI https://sqlite.org/c3ref/enable_shared_cache.html:
"Shared cache is disabled by default. It is recommended that it stay that way. In other words, do not use this routine. This interface continues to be provided for historical compatibility, but its use is discouraged. Any use of shared cache is discouraged."

ZackerySpytz reviewed Dec 31, 2020
View reviewed changes
Comment thread Doc/whatsnew/3.10.rst Outdated
(Contributed by Erlend E. Aasland in :issue:`42264`.)

* ``sqlite3.enable_shared_cache`` is now deprecated, scheduled for removal in
Python 3.12. The method is undocumented, and it's use is strongly

ZackerySpytz Dec 31, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
Python 3.12. The method is undocumented, and it's use is strongly
Python 3.12. The method is undocumented, and its use is strongly

It is incorrect to use a contraction here.

Also, it seems that sqlite3.enable_shared_cache is not a method.

erlend-aasland Dec 31, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Also, it seems that sqlite3.enable_shared_cache is not a method.

Correct, it's a built-in function. Good catch.

erlend-aasland Dec 31, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

See 7d52671. Is the new phrasing acceptable?

Comment thread Misc/NEWS.d/next/Library/2020-12-30-14-56-25.bpo-24464.vbNVHe.rst Outdated
Comment thread Misc/NEWS.d/next/Library/2020-12-30-14-56-25.bpo-24464.vbNVHe.rst Outdated
Erlend Egeberg Aasland and others added 4 commits December 31, 2020 20:05
Fix typo: it's => its
13a1eb1 
Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Add missing punctuation mark.
f93c455 
Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Fix typo: it's => its
5fa5918 
Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Address review: it's not a method, it's a built-in function
7d52671

erlend-aasland commented Dec 31, 2020

Copy link
Copy Markdown
Contributor Author

PTAL, @ZackerySpytz

merwok reviewed Jan 4, 2021
View reviewed changes
Comment thread Lib/sqlite3/dbapi2.py
merwok reviewed Jan 4, 2021
View reviewed changes
Comment thread Lib/sqlite3/dbapi2.py Outdated
merwok reviewed Jan 4, 2021
View reviewed changes
Comment thread Lib/sqlite3/dbapi2.py Outdated
Erlend E. Aasland and others added 2 commits January 5, 2021 00:09
berkerpeksag approved these changes Jan 6, 2021
View reviewed changes

berkerpeksag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

erlend-aasland commented Jan 6, 2021

Copy link
Copy Markdown
Contributor Author

Thanks, and thanks for the markup fix, @berkerpeksag !

berkerpeksag commented Jan 6, 2021

Copy link
Copy Markdown
Member

All failed tests seem to be unrelated and flaky. Will continue with merge.

berkerpeksag merged commit ddb5e11 into python:master Jan 6, 2021
erlend-aasland deleted the sqlite-shared-cache branch January 6, 2021 00:36
erlend-aasland mentioned this pull request Jan 8, 2021
Merged
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
bpo-24464: Deprecate sqlite3.enable_shared_cache (pythonGH-24008)
f2c6a84
This was referenced May 9, 2022
Closed
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request May 9, 2022
pythongh-92547: Remove deprecated sqlite3 features
8312697 
The following sqlite3 features were deprecated in 3.10, scheduled for
removal in 3.12:

- sqlite3.OptimizedUnicode (pythongh-23163)
- sqlite3.enable_shared_cache (pythongh-24008)

Signed-off-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit that referenced this pull request May 16, 2022
gh-92547: Remove deprecated sqlite3 features (#92548)
00f22e8 
The following sqlite3 features were deprecated in 3.10, scheduled for
removal in 3.12:

- sqlite3.OptimizedUnicode (gh-23163)
- sqlite3.enable_shared_cache (gh-24008)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Signed-off-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland mentioned this pull request Jun 5, 2022
Merged
brianschubert mentioned this pull request Aug 1, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

merwok merwok left review comments
berkerpeksag berkerpeksag approved these changes
ronaldoussoren Awaiting requested review from ronaldoussoren
+1 more reviewer
ZackerySpytz ZackerySpytz left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL