FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-24464: Fix sqlite3.enable_shared_cache() deprecation wrapper by erlend-aasland · Pull Request #24170 · python/cpython · GitHub

/ cpython Public

bpo-24464: Fix sqlite3.enable_shared_cache() deprecation wrapper - #24170

Merged
berkerpeksag merged 5 commits into
python:masterfrom
erlend-aasland:bpo-24464-fix
Jan 9, 2021
ConversationCommits (5)ChecksFiles changed
Merged

bpo-24464: Fix sqlite3.enable_shared_cache() deprecation wrapper#24170
berkerpeksag merged 5 commits into
python:masterfrom
erlend-aasland:bpo-24464-fix

Conversation

erlend-aasland commented Jan 8, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

erlend-aasland commented Jan 8, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for spotting this, @mrluanma.

erlend-aasland commented Jan 8, 2021

Copy link
Copy Markdown
Contributor Author

@berkerpeksag or @serhiy-storchaka, can one of you review and apply this? #skipnews

erlend-aasland changed the title bpo-24464: Call sqlite3.enable_shared_cache() from deprecation wrapper bpo-24464: Fix sqlite3.enable_shared_cache() deprecation wrapper Jan 8, 2021

erlend-aasland commented Jan 8, 2021

Copy link
Copy Markdown
Contributor Author

Regression caused by #24008

erlend-aasland marked this pull request as draft January 8, 2021 19:48
erlend-aasland marked this pull request as ready for review January 8, 2021 20:48

erlend-aasland commented Jan 8, 2021

Copy link
Copy Markdown
Contributor Author

Fixed macOS tests. Ready for review, @berkerpeksag / @serhiy-storchaka

berkerpeksag requested changes Jan 8, 2021
View reviewed changes
Comment thread Lib/sqlite3/test/dbapi.py Outdated

bedevere-bot commented Jan 8, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

erlend-aasland commented Jan 9, 2021

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

bedevere-bot commented Jan 9, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

berkerpeksag merged commit d16f617 into python:master Jan 9, 2021

berkerpeksag commented Jan 9, 2021

Copy link
Copy Markdown
Member

Thank you.

erlend-aasland deleted the bpo-24464-fix branch January 9, 2021 11:50
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
bpo-24464: Fix sqlite3.enable_shared_cache() deprecation wrapper (pyt…
7825cfe 
…honGH-24170)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

berkerpeksag berkerpeksag approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL